TestingParty08: comment form location

OK so that patch has got in, but it looks like setCommentForm is mixing up two different settings anyway.

  /**
   * Set comment form setting.
   *
   * @param boolean $enabled Form value.
   */
  function setCommentForm($enabled) {
    $this->setCommentSettings('comment_form_location', ($enabled ? '1' : '3'), 'Comment controls '. ($enabled ? 'enabled' : 'disabled') .'.');
  }

The position of the comment form (on the same page as the node/comments or on a separate page) is a completely different issue to whether comment controls were enabled or disabled and their position (above, below or both).

Should probably be something like this (completely untested).

  /**
   * Set comment form setting.
   *
   * @param boolean $below Form value.
   */
  function setCommentForm($below) {
    $this->setCommentSettings('comment_form_location', ($below ? '1' : '0'), 'Comment form ' . ($below ? 'below' : 'separate page')  . '.');
  }

Have to say this vindicates how confusing comment controls were though....

I appreciate the irony of uploading an untested patch to the SimpleTest issue queue and hang my head in shame. Won't have time to try tests etc. until at least this weekend. Hopefully this is trivial enough that I didn't do anything stupid.

Had a quick look although still only time for visual review, comment module uses the COMMENT_FORM_SEPARATE_PAGE constant in nearly all cases except for the very end of comment_render.

Additionally, testFormOnPage only verifies that setCommentForm(TRUE) results in the comment form being rendered on the page (which it should because that bit's right), it doesn't check the converse. This explains why the tests were passing I guess.

Also, moving to core!

comment settings are per node type, so this is more wrong than I originally thought. Moving to tests component.

Retitling this since although the comment controls are mentioned, that's just a symptom of a wider problem in the test - this section bears no resemblance to what actually happens in core at all.

Also marking postponed pending this general cleanup: http://drupal.org/node/251843

The comment form location is now a per-node-type setting. This isn't reflected in the current comment.test - so it needs changing to use the proper variables, and then a check to ensure the form shows up on the correct pages.