Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
comment.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Apr 2015 at 09:13 UTC
Updated:
26 Apr 2015 at 10:04 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
tstoecklerAdding issue summary and beta evaluation.
Comment #2
tstoecklerHere we go.
Tagging Needs usability review and adding an "after" screenshot to the issue summary. The "before" screenshot is identical but for the ellipsis, so I hope that's sufficient.
Comment #4
tstoecklerSorry, had an outdated 8.0.x locally.
Comment #6
tstoecklerFixed the tests.
Comment #7
Shivam Agarwal commented#tstoeckler This patch doesn't apply on my system. Following error is thrown :
Comment #9
Shivam Agarwal commentedI was going through your patch and found that following thing doesn't exist in my files :
Comment #10
tstoeckler@Shivam Agarwal: Please make sure you have the latest 8.0.x code. The automated testing infrastructure had no problem applying the patch so it seems there must be some problem with your setup.
Comment #11
Shivam Agarwal commented@tstoeckler, I already have latest code with clean head. I have cross checked it twice. Maybe I am missing with something else. Can you please guide me on it?
Comment #12
mikeker commentedThe patch in #6 applies cleanly. @Shivam Agarwal: I'm not sure what is causing the errors you're seeing but them seem to be limited to your localhost.
I've tested the patch and verified it works as expected and would move it to RTBC except for the "Needs usability review" tag, which I don't feel qualified to do.
This gets a big +1 from me! Thank you @tstoeckler.
Comment #13
Shivam Agarwal commentedYes, patch works! Screenshot attached.
Comment #16
tstoecklerComment #17
Shivam Agarwal commentedScreenshot attached in #13.
Comment #18
alexpottCommitted b85ec52 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation.