Within "Link Settings" if you have 'Link the title to the node' = 'site' and 'Enable click-tracking' = 'yes' the url to go to a site should be weblinks/goto/n. This is correctly shown when a link is viewed on the main links page but but when displaying in a group we get weblinks/weblinks/goto/n which produces 'page not found'. The url is probably being defined as relative to the page it is on, so it works at the top level but fails when viewed in a group such as /weblinks/tid.

Also when the Drupal site does not have 'clean urls' enabled the title link fails because it does not contain the required ?q=

[I know I said that we'd not create any more 7.x blocker issues, but this is important enough. We can't release 7.x with known bugs which produce '404 page not found' links within our own generated content. I will work on this]

CommentFileSizeAuthor
#2 2463501_2.fix_link_url.patch1.2 KBjonathan1055
#2 2463501_2.fix_link_url.patch.debug_.txt5.33 KBjonathan1055

Comments

GStegemann’s picture

GStegemann commented

I could reproduce that as well.

Sure, this is a 7.x blocker issue. Thanks.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new 2463501_2.fix_link_url.patch.debug_.txt5.33 KB
new 2463501_2.fix_link_url.patch1.2 KB

I've worked out what is happening and luckily the solution is simple, but here are my full notes, for reference:

The setting 'link the title to the node' is controlled by variable weblinks_title_link, 1=node, 0=site. Default is TRUE(1) = node
The setting 'enable click-tracking' is controlled by variable weblinks_redirect

There is potential for confusion, because the admin setting variable 'weblinks_title_link' is also the name of the node property $node->weblinks_title_link which holds the actual url to go to.

weblinks_weblinks_preprocess() calls weblinks_node_view.tpl.php. Then we get weblinks_preprocess_node() which has $variables[node_url] as the value set in .tpl.php. It is this $variables[node_url] which is used behind the node title, via node.tpl.php

weblinks_node_view.tpl.php generates the link to display the site's url, and when click-count enabled (variable weblinks_redirect is true), the value is $node->weblinks_title_link = 'weblinks/goto/'. $node->nid;. This is the correct raw url and produces the correct href for the actual weblink site (as written in the .tpl) because this also uses l(). But the same $node->weblinks_title_link value when reused later behind the node title gets the wrong final value because it is relative to the current page. Adding url( ) around the value fixes it for all conbinations of click-track on/off and link to site/node. I have also tested it with clean urls not enabled and when Drupal is installed in a subdirectory.

Attached are two patches, one with full debug, where the links are manipulated to see what is being done. The second patch is a clean fix of the code.

GStegemann’s picture

GStegemann commented
Status: Needs review » Reviewed & tested by the community

Tested and works. Good, that sometimes things are simple to fix.

There is potential for confusion,

Yes, I also had difficulties to understand the code. Thanks for your added detailed comment.

  • jonathan1055 committed 075970b on 7.x-1.x 
    Issue #2463501 by jonathan1055: Link url produces 404 when click-count...
jonathan1055’s picture

jonathan1055 commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing.
Yes, after I have done any indepth analysis of a bug, it is worth recording the details here, and adding a few more comments to the code.

  • jonathan1055 committed bb95cd0 on 6.x-2.x 
    Issue #2463501 by jonathan1055: D6 same fix - Link url produces 404 when...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.