Clean-up remaining test members in module tests - ensure property definition and use of camelCase naming convention

Please review.

Let me see now.

Yeah!

Let me see now.

This looks good @rpayanm. I reviewed the changes and they all look great. Just a little nitpick before I RTBC this:

1. +++ b/core/modules/block_content/src/Tests/Views/BlockContentFieldFilterTest.php
   @@ -34,7 +34,7 @@ class BlockContentFieldFilterTest extends BlockContentTestBase {
   -  public $block_content_infos = array();
   +  public $blockContentInfos = array();
   
   @@ -54,17 +54,17 @@ function setUp() {
   -    $block_content = $this->createBlockContent(array('info' => $this->block_content_infos['en'], 'langcode' => 'en', 'type' => 'basic', 'body' => array(array('value' => $this->block_content_infos['en']))));
   +    $block_content = $this->createBlockContent(array('info' => $this->blockContentInfos['en'], 'langcode' => 'en', 'type' => 'basic', 'body' => array(array('value' => $this->blockContentInfos['en']))));
   ...
   +      $translation = $block_content->addTranslation($langcode, array('info' => $this->blockContentInfos[$langcode]));
   
   +++ b/core/modules/node/src/Tests/NodeAccessBaseTableTest.php
   @@ -59,10 +92,12 @@ function testNodeAccessBasic() {
   +    $titles = array();
   ...
   +    $private_nodes = array();
   
   @@ -149,11 +184,11 @@ function testNodeAccessBasic() {
   +      $this->nidsVisible = array();
   
   +++ b/core/modules/node/src/Tests/NodeAdminTest.php
   @@ -38,9 +59,9 @@ protected function setUp() {
   +    $this->baseUser1 = $this->drupalCreateUser(array('access content overview'));
   +    $this->baseUser2 = $this->drupalCreateUser(array('access content overview', 'view own unpublished content'));
   +    $this->baseUser3 = $this->drupalCreateUser(array('access content overview', 'bypass node access'));
   
   +++ b/core/modules/node/src/Tests/NodeRevisionPermissionsTest.php
   @@ -13,7 +13,19 @@
   +  protected $nodeRevisions = array();
   
   +++ b/core/modules/node/src/Tests/Views/NodeFieldFilterTest.php
   @@ -33,7 +33,7 @@ class NodeFieldFilterTest extends NodeTestBase {
   +  public $nodeTitles = array();
   
   +++ b/core/modules/node/src/Tests/Views/NodeLanguageTest.php
   @@ -37,7 +37,7 @@ class NodeLanguageTest extends NodeTestBase {
   +  public $nodeTitles = array();
   
   +++ b/core/modules/views/src/Tests/Plugin/NumericFormatPluralTest.php
   @@ -36,13 +36,13 @@ class NumericFormatPluralTest extends ViewTestBase {
   +    $this->webUser = $this->drupalCreateUser(array('administer views', 'administer languages'));
   

   As long as they don't change the diff hunk size I'd say may as well use the short array syntax.

2. +++ b/core/modules/node/src/Tests/NodeAdminTest.php
   @@ -23,6 +23,27 @@ class NodeAdminTest extends NodeTestBase {
   +  protected $baseUser3;
   +  ¶
   +  /**
   

   Got some extra whitespace left in here.

Here is the regular expression I used to weed out any stragglers... which there are none.

\$this\->[^(;\s]+_[^(;\s]+

Fixed both points in #10.

Awesome, thank you @hussainweb.

It doesn't look like there's overlap, but this issue looks like a cleanup issue after the rest of the module test issues from the meta are done.

There's only one remaining issue in this scope, and it's for the forum module: #2396649: Clean-up forum module test members - ensure property definition and use of camelCase naming convention

So just avoid forum module for now. :-)

I'd also say this issue should be postponed on that one, but let's keep going here if there's anything else to add.

+++ b/core/modules/views/src/Tests/Plugin/NumericFormatPluralTest.php
@@ -36,13 +36,13 @@ class NumericFormatPluralTest extends ViewTestBase {
    *
    * @var \Drupal\user\UserInterface
    */
-  protected $web_user;
+  protected $webUser;
...
-    $this->web_user = $this->drupalCreateUser(array('administer views', 'administer languages'));
-    $this->drupalLogin($this->web_user);
+    $this->webUser = $this->drupalCreateUser(['administer views', 'administer languages']);
+    $this->drupalLogin($this->webUser);

No need for the property.

Thanks @cilefen for the quick fix.

Committed b75b691 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.