demo module: Multilingual setup

I added the Demo component.

Extended the demo module for multilingual support.

Fixed the failing test.

FIxed a schema config.

Changed the test and added the config files.

Fixed the test fails - some configuration for translating text+image were missing.

1. +++ b/modules/paragraphs_demo/config/install/language.content_settings.node.paragraphed_content_demo.yml
   @@ -0,0 +1,16 @@
   +uuid: 872a47fc-77da-4589-a537-55325e31170a
   

   I think the UUID should be removed.

2. +++ b/src/Tests/ParagraphsTranslationTest.php
   @@ -38,10 +33,7 @@ class ParagraphsTranslationTest extends WebTestBase {
   +    \Drupal::service('entity.definition_update_manager')->applyUpdates();
   
   @@ -112,7 +79,7 @@ class ParagraphsTranslationTest extends WebTestBase {
   -    $this->clickLink(t('Add'));
   

   Is there any other way to add French translation (e.g. clicking a button somewhere?) in tests, except visting /fr/node/1/translations/add/en/fr directly?

Thanks.

1.) Done.
2.) I think hardcoding the link is fine. clickLink('Add') doesn't work now because it clicks on the first Add button that it finds. But now, after loading the languages from the configs we have them in different order...

I'm adding a test for the demo module now.
Considering 2.) in #16: clickLink also has an optional second parameter which is the index of the button to click. Messy but it works. I'll upload a working patch tomorrow hopefully. My test for the demo module still has a schema error

Here is the test I was talking about up there, just so Saša might continue working on it.

An updated version. It's supposed to pass the tests but I'm having some problems locally (last drupalPostForm returns a 500 error message).

Re-made the test from scratch and added the checks for the default configurations.

Extended the test with paragraphs creation.

Corrected the usage. The other Paragraphs tests use the simpletest WebTestBase, the demo test now does as well.

I tried it with multiline description, but it doesn't really work. Feedback welcome (keep it like it is? Put it on one line?). I also changed the package (capitalisation) so all paragraphs modules are grouped together (there were 2 groups before).

And an interdiff of which shows the changes.

https://www.drupal.org/node/2506497 already changed the paragraphs group, rebase necessary.

Rebased and reviewed, ready for commit if reviewed by someone else.

When I save a node (new or existing), I get:

Drupal\Core\Entity\EntityStorageException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'content_translation_source' in 'field list': INSERT INTO {paragraphs_item_field_data} (id, revision_id, type, langcode, uid, created, changed, default_langcode, content_translation_source, content_translation_outdated, content_translation_status) VALUES ...

Sometimes when I visit the content overview, I get this PHP notice:

Notice: Undefined index: content_translation_source in Drupal\Core\Entity\Sql\SqlContentEntityStorage->loadFromSharedTables() (line 715 of core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Drupal\Core\Entity\Sql\SqlContentEntityStorage->loadFromSharedTables(Array, Array)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->mapFromStorageRecords(Array)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->getFromStorage(Array)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->doLoadMultiple(Array)
Drupal\Core\Entity\EntityStorageBase->loadMultiple(Array)
entity_load_multiple('node', Array)

This (paragraphs + paragraphs_demo) doesn't depend on any other contrib module than entity_reference_revisions, right?

1. +++ b/modules/paragraphs_demo/paragraphs_demo.info.yml
   @@ -1,4 +1,6 @@
   +description: >
   +  Multilingual demo for paragraphs. It adds CSS for responsive wrapping as well as the following paragraph types:
   +  User, Images, Text, Image + Text, Text + Image
   

   To make line breaks matter in YAML strings, you should use |, not >. But it doesn't really matter, because the module description is just printed in the HTML and line breaks are ignored anyway. IMHO that's okay, the line break is not really necessary here.

2. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,144 @@
   +  function setUp() {
   

   Should be protected.

3. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,144 @@
   +  }
   +
   +  protected function testParagraphsCreation() {
   

   Test method needs doc.

4. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,144 @@
   +}
   +
   

   I get

   <stdin>:435: new blank line at EOF.
   +
   warning: 1 line adds whitespace errors.

   when applying.

The feedback has been implemented! Now we might want to add a demo node with paragraphs and translate that, the paragraphs_demo.install has plenty of space to do things.

Updated the test, assertOptionSelected didn't have a result for it's xpath call, doing it manually with an assertRaw for the HTML now.

The assertOptionSelected calls must be failing because of #1305882: drupal_html_id() considered harmful; remove ajax_html_ids to use GET (not POST) AJAX requests (Core).

But assertRaw seems like an okay fix.

Added the introduction on the frontpage.

Concerning #41: #2530092: AssertOptionSelected() does not work for dynamic HTML IDs

The easiest solution right now:

#2530044: Edit widget test is failing

Revert the assertRaw(), add the fixed assertOptionSelected() function temporarily.

Fixed the test fails. Because of the new welcome node in the demo, the index of the node in the test has to be changed to 2.

+++ b/src/Tests/ParagraphsAdministrationTest.php
@@ -224,7 +224,8 @@ class ParagraphsAdministrationTest extends WebTestBase {
-    $this->assertOptionSelected('edit-fields-field-paragraphs-settings-edit-form-settings-add-mode', 'button', 'Updated value is correct!.');
+    // Assert the 'Buttons' option is selected.
+    $this->assertRaw('<option value="button" selected>Buttons</option>');
 
     // Add two Text + Image paragraphs in article.
     $this->drupalGet('node/add/article');
@@ -272,7 +273,8 @@ class ParagraphsAdministrationTest extends WebTestBase {

@@ -272,7 +273,8 @@ class ParagraphsAdministrationTest extends WebTestBase {
     // Check if the setting is stored.
     $this->assertText('Edit mode: Closed', 'Checking the settings value.');
     $this->drupalPostAjaxForm(NULL, array(), "field_paragraphs_settings_edit");
-    $this->assertOptionSelected('edit-fields-field-paragraphs-settings-edit-form-settings-edit-mode', 'closed', 'Updated value correctly.');
+    // Assert the 'Closed' option is selected.
+    $this->assertRaw('<option value="closed" selected>Closed</option>');
     $this->drupalGet('node/1/edit');
     // The textareas for paragraphs should not be visible.
     $this->assertNoRaw('field_paragraphs[0][subform][field_text][0][value]');
@@ -296,7 +298,8 @@ class ParagraphsAdministrationTest extends WebTestBase {

@@ -296,7 +298,8 @@ class ParagraphsAdministrationTest extends WebTestBase {
     // Test for open option.
     $this->drupalGet('admin/structure/types/manage/article/form-display');
     $this->drupalPostAjaxForm(NULL, array(), "field_paragraphs_settings_edit");
-    $this->assertOptionSelected('edit-fields-field-paragraphs-settings-edit-form-settings-edit-mode', 'preview', 'Updated value correctly.');
+    // Assert the 'Preview' option is selected.
+    $this->assertRaw('<option value="preview" selected>Preview</option>');

Those should be reverted. Add the fixed assertOptionSelected() method instead.

Ok, reverted back to use assertOptionSelected.

Cool stuff!

1. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,146 @@
   + *
   + * @group Paragraphs
   

   Usually the group is the module machine name.

   do the other tests also use Paragraphs? Then fine...

2. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,146 @@
   +  public static $modules = array(
   +    'node',
   +    'paragraphs_demo',
   +  );
   

   paragraphs_demo should depend on node.module, not the test.

3. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,146 @@
   +    $this->drupalGet('admin/config/regional/content-language');
   +    $this->assertFieldChecked('edit-entity-types-node');
   +    $this->assertFieldChecked('edit-entity-types-paragraph');
   +    $this->assertFieldChecked('edit-settings-node-paragraphed-content-demo-translatable');
   +    $this->assertFieldChecked('edit-settings-paragraph-images-translatable');
   +    $this->assertFieldChecked('edit-settings-paragraph-image-text-translatable');
   +    $this->assertFieldChecked('edit-settings-paragraph-text-translatable');
   +    $this->assertFieldChecked('edit-settings-paragraph-text-image-translatable');
   +    $this->assertFieldChecked('edit-settings-paragraph-user-translatable');
   

   Can we also add an assertion that the paragraphs reference field is *not* checked?

4. +++ b/modules/paragraphs_demo/src/Tests/ParagraphsDemoTest.php
   @@ -0,0 +1,146 @@
   +
   +  }
   +
   +  /**
   +   * Test creating content of demo paragraph type.
   +   */
   +  protected function testParagraphsCreation() {
   

   This probably makes the test almost twice as slow. I'd combine those two methods together.

5. +++ b/src/Tests/ParagraphsTranslationTest.php
   @@ -38,10 +33,7 @@ class ParagraphsTranslationTest extends WebTestBase {
       */
      protected function setUp() {
        parent::setUp();
   -    $language = ConfigurableLanguage::createFromLangcode('de');
   -    $language->save();
   -    $language = ConfigurableLanguage::createFromLangcode('fr');
   -    $language->save();
   +    \Drupal::service('entity.definition_update_manager')->applyUpdates();
      }
   

   applyUpdates() is now called in paragraphs_demo_install(), this shouldn't be needed anymore.

6. +++ b/src/Tests/ParagraphsTranslationTest.php
   @@ -112,7 +79,7 @@ class ParagraphsTranslationTest extends WebTestBase {
        $this->clickLink(t('Translate'));
   -    $this->clickLink(t('Add'));
   +    $this->drupalGet('/fr/node/2/translations/add/en/fr');
   

   No leading /.

Fixes for the comments above.

+++ b/src/Tests/ParagraphsTranslationTest.php
@@ -112,7 +78,7 @@ class ParagraphsTranslationTest extends WebTestBase {
-    $this->clickLink(t('Add'));
+    $this->drupalGet('fr/node/2/translations/add/en/fr');

Changing from clickLink to drupalGet is a bit much I'd say, just change it to $this->clickLink(t('Add'), 1); to click the second Add link on the page. Now we do the same thing as before and actually use the UI buttons instead of clicking links and then suddenly drupalGetting to the place we want to go to.

Thanks, totally forgot about this easy way. :)

Now it's perfect! ;)

Yes, looks good to me as well.

Thanks guys, commited to dev, really appreciate all your hard work!