Ignore root level vendor/ during testbot lint

Here's some fu for you;)

http://3v4l.org/n3ZfN

Regex makes sense to me.

+++ b/review/drupal/pifr_drupal.client.inc
@@ -172,13 +172,13 @@ class pifr_client_review_pifr_drupal extends pifr_client_review {
+    // non-Drupal code  which we do not want to run through coder, and

There's an extra space between "code" and "which", but that's not a big deal.

"php" should be capitalized if I recall correctly.

+++ b/review/drupal/pifr_drupal.client.inc
@@ -172,13 +172,13 @@ class pifr_client_review_pifr_drupal extends pifr_client_review {
+    // potentially contains PHP 5.4 code which will not pass the syntax check.

Isn't it PHP 5.5 code that makes it fail? IIRC, the error that caused the tests to fail was Guzzle's use of PHP 5.5 in some places.

Let's just remove the exact version ("potentially contains PHP code which will not pass the syntax check"). We can update it to say "5.5" but that too will be weird once we raise our requirement to 5.5 and the libraries include some other >5.5 code.

I think that is still inaccurate. We are already using PHP 5.4 code in Drupal 8 core and the executable works fine with that. The testbot fails with Guzzle as some of the files use PHP 5.5 keywords/operators (I can't remember what exactly). Normally, that class in Guzzle is optional and loaded only if PHP 5.5 is available and we don't have a problem when actually running or testing Drupal 8.

The message should say that we are just skipping syntax checks for all the files in (core/)?vendor/ directory as that is not our code anyway.

+1 this makes sense.

LGTM as well. Committed and pushed.