Comments

sachin.bansal’s picture

StatusFileSize
new902 bytes

Status: Needs review » Needs work

The last submitted patch, 1: FeedsProcessor.inc_2460657.patch, failed testing.

rreiss’s picture

Version: 7.x-2.0-alpha8 » 7.x-2.x-dev
Status: Needs work » Needs review
Issue tags: +log
StatusFileSize
new1.63 KB

Patch from latest 7.x-2.x-dev branch is attached.
Please review and commit to the latest dev. branch.

Thanks ;)

Status: Needs review » Needs work

The last submitted patch, 3: skipped_status_message-2460657-#3.patch, failed testing.

megachriz’s picture

I think that the patch failed to apply by the testbot because of the number sign in the patch name.

+++ b/plugins/FeedsProcessor.inc
@@ -467,6 +470,16 @@ abstract class FeedsProcessor extends FeedsPlugin {
+    if ($state->skipped) {
+      $messages[] = array(
+        'message' => format_plural(
+          $state->skipped,
+          'Skipped @number @entity.',
+          'Skipped @number @entities.',
+          array('@number' => $state->skipped) + $tokens
+        )
+      );
+    }
     if (empty($messages)) {
       $messages[] = array(
         'message' => t('There are no new @entities.', array('@entities' => strtolower($info['label plural']))),

I think that this change will cause that the message 'There are no new entities' will never appear when there is at least one item in the source. Not tested though.

rreiss’s picture

Status: Needs work » Needs review
StatusFileSize
new1.61 KB

The patch failed to apply because convention issues.. Re-uploading the patch.

Status: Needs review » Needs work

The last submitted patch, 6: feeds-skip-status-2460657-6.patch, failed testing.

rreiss’s picture

Status: Needs work » Needs review
StatusFileSize
new1.77 KB

Fixed the messages issue @MegaChriz mentioned.

Status: Needs review » Needs work

The last submitted patch, 8: feeds-skip-status-2460657-8.patch, failed testing.

rreiss’s picture

StatusFileSize
new5.18 KB

Re-patch this time with tests and a real fix..
Hope this time it will work.

rreiss’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: feeds-skip-status-2460657-10.patch, failed testing.

rreiss’s picture

Status: Needs work » Needs review
StatusFileSize
new5.19 KB

Maybe it'll work on the 5th time :S
More adjustments to the module's tests.

Status: Needs review » Needs work

The last submitted patch, 13: feeds-skip-status-2460657-13.patch, failed testing.

bluegeek9’s picture

Status: Needs work » Closed (outdated)
Issue tags: -log

Drupal 7 reached end of life and the D7 version of Feeds is no longer being developed. To keep the issue queue focused on supported versions, we’re closing older D7 issues.

If you still have questions about using Feeds on Drupal 7, feel free to ask. While we won’t fix D7 bugs anymore, we’re happy to offer guidance to help you move forward. You can do so by opening (or reopening) a D7 issue, or by reaching out in the #feeds channel on Drupal Slack.

If this issue is still relevant for Drupal 10+, please open a follow-up issue or merge request with proposed changes. Contributions are always welcome!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.