Closed (duplicate)
Project:
Flag
Version:
8.x-4.x-dev
Component:
Flag core
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Mar 2015 at 15:19 UTC
Updated:
27 Mar 2015 at 09:45 UTC
Jump to comment: Most recent
This is a issue that has fallen out from a discussion in #2456903: Investigate regenerating the module using Drupal Console
In light of what we have for the flagging entity have versus what the console command outputs when scaffolding a new Content entity
This aspect of the flagging entity need to be refactored.
Here is a @socketwench 's quote from
https://www.drupal.org/node/2456903#comment-9762527
One thing that does make sense is the views data handler (FlaggingViewsData)...
Comments
Comment #1
joachim commentedSee also #2410011: add a views_data handler.
Comment #2
martin107 commentedAh yes it seems I am charging in again like a bull in a china shop....
That one should get a higher priority :)
Comment #3
joachim commentedNo, it's great to have people contributing and having new ideas! :)
I'm not sure the order these two issues should be taken in. #2410011: add a views_data handler appears to be about dealing with a change in core API. But then, tackling that and rewriting it all seems a waste if with this issue it turns out we can throw some of our code away and let core do the basics for us.
So I would be inclined to say we try this one first, see what core provides OOTB, and see how that compares with what we need.
Comment #4
berdirI think they are really duplicates.
#2410011: add a views_data handler already uses an EntityViewsData handler, so it is doing exactly what this issue is proposing.