If option 'Place version in own column' is enabled, then modules that have no version (local dev modules and even some contrib modules on d.o) the remaining items are all shifted one column to the left.

Current:
blank version before fix

CommentFileSizeAuthor
#4 2460135-4.module_filter.show_version.patch827 bytesjonathan1055
#4 module filter with blank module version - after fix.png211.2 KBjonathan1055
#4 module filter with blank module version - before fix.png199.63 KBjonathan1055
#1 module_filter_7.x-2.x-dev-version_display-2460135.patch1.77 KBslhemanthkumar

Comments

slhemanthkumar’s picture

slhemanthkumar commented
Component: User interface » Code
StatusFileSize
new module_filter_7.x-2.x-dev-version_display-2460135.patch1.77 KB

Hi pmackay,

I too face the same issue, if the version number not exist then the module is taking the description, and I fixed it. Please find the patch for the issue. It will helpful for you.

Thanks,
Hemanth

slhemanthkumar’s picture

slhemanthkumar commented
Status: Active » Needs review

Please review the above patch and push the same in next release

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work

The 4 year old patch to module_filter.theme.inc needs work...

When trying to apply the patch with git apply:
error: unrecognized input

When trying to apply the patch with patch apply:

patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.
jonathan1055’s picture

jonathan1055 commented
Title: Description in version column » When version is blank the description appears in version column
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new module filter with blank module version - before fix.png199.63 KB
new module filter with blank module version - after fix.png211.2 KB
new 2460135-4.module_filter.show_version.patch827 bytes

The first line of the patch had a/module_filter/module_filter.theme.inc which may have caused you a problem, as contrib module patches are usually created from within that module's root folder. Here's a patch which has a/module_filter.theme.inc

Screen shot with fix:
blank version after fix

solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community

Works for me.

jonathan1055’s picture

jonathan1055 commented

This is still a problem in 7.x-2.2 but the patch #4 still applies OK to the latest dev. Hope this can be committed, as it is a very simple fix.

andrtroe’s picture

andrtroe commented
Issue tags: +Module Filter Release 7.x-2.3

  • jonathan1055 authored 87e67c2 on 7.x-2.x 
    Issue #2460135 by jonathan1055, slhemanthkumar, pmackay, Chris Matthews...
andrtroe’s picture

andrtroe commented
Status: Reviewed & tested by the community » Fixed
jonathan1055’s picture

jonathan1055 commented

Thank you @andrey.troeglazov

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.