Problem/Motivation
#2457653: System.site langcode is both used as a file language code and a site language code has introduced new config item in system.site for default language code, which is not updated in docblock of Drupal\language\LanguageServiceProvider::getDefaultLanguageValues()
Proposed resolution
Update the docblock.
Remaining tasks
User interface changes
N/A
API changes
N/A
Original report by @epari.siva
Comment | File | Size | Author |
---|---|---|---|
#8 | 2460027-8.patch | 770 bytes | vijaycs85 |
Comments
Comment #1
siva_epari CreditAttribution: siva_epari commentedComment #2
siva_epari CreditAttribution: siva_epari commentedComment #3
vijaycs85good catch @epari.siva. Let's add some test and update issue summary with beta-evaluation.
Comment #4
vijaycs85Adding to D8MI sprint...
Comment #5
Gábor HojtsyNonono. The default_langcode is intended there, see #2457653: System.site langcode is both used as a file language code and a site language code. We can swallow a notice there I guess.
Comment #7
siva_epari CreditAttribution: siva_epari commentedReinstalling Drupal fixed it. So, we can close this issue?
Comment #8
vijaycs85yeah, I can't reproduce either.
At least we can use this issue to update the documentation.
Comment #9
vijaycs85Comment #10
Gábor HojtsyLooks good to me.
Comment #11
jhodgdondoc fix++
Comment #12
alexpottNice find. Docs are not frozen in beta. Committed 581c3a0 and pushed to 8.0.x. Thanks!
Comment #14
Gábor HojtsyAmazing, thanks.