Problem/Motivation

While this seemed like a neat trick originally, @berdir and others found it confusing on #2212069: Non-English Drupal sites get default configuration in English, edited in English, originals not actually used if translated that the system.site language code is both used as a language code for that file itself and the default langcode for the whole site.

Proposed resolution

Introduce a default_langcode key that is used for the site default.

Remaining tasks

Do it. Ensure tests pass.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#4 interdiff.txt613 bytesgábor hojtsy
#4 2457653-4.patch15.92 KBgábor hojtsy
#2 2457653.patch15.32 KBgábor hojtsy

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Assigned: Unassigned » gábor hojtsy
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Needs review
StatusFileSize
new 2457653.patch15.32 KB

It is hard to tell all the instances 100% so here are the ones I found immediately. Let's see what fails with this.

Status: Needs review » Needs work

The last submitted patch, 2: 2457653.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new 2457653-4.patch15.92 KB
new interdiff.txt613 bytes

Fix config schema.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +D8 upgrade path

This looks good. It is a hard break for existing sites but very easy to fix.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, this looks good to me as well.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Ups, change record :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Reviewed & tested by the community

Posted https://www.drupal.org/node/2459073

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Also speculatively opened head2head issue; #2459119: Upgrade path for #2457653 (system.site langcode).

  • catch committed 364a6e9 on 
    Issue #2457653 by Gábor Hojtsy: System.site langcode is both used as a...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Thanks, published the change notice.

  • catch committed 079a52b on 8.0.x 
    Revert "Issue #2457653 by Gábor Hojtsy: System.site langcode is both...

  • catch committed 3fbe92b on 8.0.x 
    Revert "Revert "Issue #2457653 by Gábor Hojtsy: System.site langcode is...
catch’s picture

catch
he/him
Primary language English
commented

I reverted then unreverted this due to an unrelated regression in beta 8 so we could roll beta 9 with no schema/config changes from beta 8. Nothing to do with this issue directly.

siva_epari’s picture

siva_epari commented
Related issues: +#2460027: Update the documentation of Drupal\language\LanguageServiceProvider::getDefaultLanguageValues()
siva_epari’s picture

siva_epari commented
Related issues: -#2460027: Update the documentation of Drupal\language\LanguageServiceProvider::getDefaultLanguageValues()

Added #2460027 as child issue instead.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.