Problem/Motivation

The only users of #cache[expire] in all of Drupal core is BlockViewBuilder.

We currently have both #cache[max-age] and #cache[expire]. max-age bubbles, expire doesn't.

max-age matches HTTP terminology & semantics. expire doesn't (in HTTP 1.0, there's expires, note the additional 's', which all best practices recommend against in favor of max-age).

Proposed resolution

Remove it.

Remaining tasks

None.

User interface changes

None.

API changes

Removed #cache[expire], use #cache[max-age] instead.

CommentFileSizeAuthor
#1 render_cache_expire-2458993-1.patch4.52 KBwim leers

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new render_cache_expire-2458993-1.patch4.52 KB
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks good to me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yep straightforward dead code removal.

Committed/pushed to 8.0.x, thanks!

  • catch committed 64ac1cb on 8.0.x 
    Issue #2458993 by Wim Leers: #cache[expire] is undocumented, unused,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.