Problem/Motivation

The following styles get applied to non-Ubercart fieldsets, which can break layouts.

+.vertical-tabs fieldset fieldset legend {
+ display: inline-block;
+}
+
+div.vertical-tabs .vertical-tabs-panes fieldset fieldset {
+ border: 1px solid #ccc;
+ margin: 1em 0;
+ padding: 2.5em 0 0;
+}
+
+div.vertical-tabs .vertical-tabs-panes fieldset fieldset legend {
+ display: inline-block;
+}

Proposed resolution

Revert this commit as it is not needed anymore now that #1015798: Fieldsets inside vertical tabs have no title and can't be collapsed is in Drupal core: http://cgit.drupalcode.org/ubercart/commit/?id=dd0861f

Remaining tasks

Review and commit the patch :)

User interface changes

Layout could unintentionally break before, patch fixes this.

API changes

None.

In any case a

CommentFileSizeAuthor
#1 2458727-ubercart_css-1.patch723 bytesstefan.r

Comments

stefan.r’s picture

Status: Active » Needs review
StatusFileSize
new723 bytes

  • TR committed b5464d1 on 7.x-3.x
    Issue #2458727 by stefan.r: Remove css that was used to correct a core...
tr’s picture

Priority: Major » Normal
Status: Needs review » Fixed

Thanks for catching that. I committed your patch.

(Doesn't need to be fixed in 8.x-4.x, as it was already removed there.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 1: 2458727-ubercart_css-1.patch, failed testing.

tr’s picture

Status: Needs work » Closed (fixed)

Not sure why the testbot reopened this ...