Allow disabling Drupal blocks/regions when Page is viewed

Needs a UI toggle, and \Drupal\page_manager\EventSubscriber\BlockPageDisplayVariantSubscriber::onSelectPageDisplayVariant needs to check it.

But this works just for now.

By the way, if these pass, we need tests to prove they shouldn't.

#5.1 Yes, we should.
#5.2 Not sure yet, still thinking on it.

Right now the only thing in core that uses ThirdPartySettings are config entities, so I tacked this onto Page via that.

However, instead of a nice snippet like
$variant->setThirdPartySetting('page_manager', 'no_blocks', TRUE);
we're stuck with

$settings = $page->getThirdPartySettings('page_manager', $display_variant_id);
$settings['no_blocks'] = $form_state->getValue('no_blocks');
$page->setThirdPartySetting('page_manager', $display_variant_id, $settings);

in order to key it by the variant.

It also made for some exceedingly confusing config schema wrangling, but I figured it out...

This still needs a ton of tests. That can wait until tomorrow.

It's "tomorrow"!
Still want to look into moving the settings down a level.

I pushed some commits that weren't necessarily about this feature while working on it:

• PageInterface and schema should extend config entity
• Altering display variant forms is too hard
• Do not interfere with variant selection conditions, allow block pages with no blocks to be used
• Remove obsolete third parameter passed to resolveConditions()
• Remove redundant PageFormBase::save()
• Consolidate PageAwareVariantInterface check to DisplayVariantFormBase

Still needs some web tests IMO.

That interdiff was wrong, sorry. Here's one from #7.
And that last bug is silly, getThirdPartySettings vs getThirdPartySetting

FYI: related D8 docs: https://www.drupal.org/developing/api/8/render/pipeline

1. +++ b/src/EventSubscriber/DisableBlocksDisplayVariantSubscriber.php
   @@ -0,0 +1,51 @@
   +class DisableBlocksDisplayVariantSubscriber implements EventSubscriberInterface {
   ...
   +        if (!empty($settings['no_blocks'])) {
   

   All of the wording is block-specific. But really, if there's also a PonycornPageVariant, this would override that too.

   Note that if you really want this to override anything else, then you'll also want to call $event->stopPropagation().

2. +++ b/src/EventSubscriber/DisableBlocksDisplayVariantSubscriber.php
   @@ -0,0 +1,51 @@
   +   * Selects the block page display variant.
   

   Exactly the opposite, actually :)

3. +++ b/tests/src/Unit/DisableBlocksDisplayVariantSubscriberTest.php
   @@ -0,0 +1,115 @@
   + * Contains
   + *   \Drupal\Tests\page_manager\Unit\DisableBlocksDisplayVariantSubscriberTest.
   

   Oopsie :)

Whatever happened to this feature. Has it been added? I am playing with 8.x-1.0-alpha24 , and do not see it anywhere, and would like to have this feature available. Has it been dropped?

If the feature was present then it wouldn't need a feature request. It still needs work.

A lot have changed in page_manager since #11, so I tried to keep its ideas while using the new classes interfaces and models.

I've excluded the tests as I first want to be sure my approach is correct. Specifically:

1. I'm not sure if having the opt-in option in the variant was the plan, although this is what the summary suggests.
2. I'm not sure if the way I use to get PageVariant settings is best practice.

Been lazy and thought I could get away without updating the schema.

This comes green locally.

Minor complaint, but I don't like the setting name "force_simplepage".

Something to consider - might there be other display plugins which could be listed? In other words, might it be better to make this a selector to e.g. choose between "Normal page (default)" and "Hide other blocks on the page", so that maybe there could be extended beyond these two, or would that be over-engineering it?

@DamienMcKenna I agree is terrible name, but due #13.1 I couldn't find anything better.
My original idea was to use the 'This variant owns the page, so no other/external blocks, regions, content will be displayed" naming convention, which covers #13.1 and still mention the old reference to blocks and regions. But I couldn't find a shorter key-name version. :p

I'll try to get hold of @Wim Leers at DDD.

@Wim Leers mentioned at least another module is using RenderEvents::SELECT_PAGE_DISPLAY_VARIANT event: RefreshLess.

The idea of the dropdown is a good one. I'll work on it, together with:

1. +++ b/src/EventSubscriber/ForceSimplePageVariantSubscriber.php
   @@ -0,0 +1,61 @@
   +      $routes = \Drupal::service('router.route_provider')->getRoutesByPattern($page->getPath())->all();
   

   Use dependency injection.

2. +++ b/src/EventSubscriber/ForceSimplePageVariantSubscriber.php
   @@ -0,0 +1,61 @@
   +      -10
   

   This should have a comma at the end.

Page Manager 8.x-1.x is no longer supported, closing.