The issue #1860484: Add support for Title module field adds support for the Title module, but the integration does not handle a little incompatibility between those 2 modules.

The Title field module uses hook_field_extra_fields_alter() to remove the title extra field when the replacement is enabled.

But in the same time, the Fieldable Panels Pane module uses hook_field_extra_fields_display_alter() to set the visibility of this extra field to FALSE. But at this time, the entry does not exists anymore, so that causes an error when rendering the extra field in _field_extra_fields_pre_render() :

Notice: Undefined index: weight in _field_extra_fields_pre_render() (line 716 of /home/capkopper/www/capkopper/drupal/modules/field/field.module).

There are several ways to fix that, but the simplest seems to be a basic test before modifying the visibility...

CommentFileSizeAuthor
#3 fieldable_panels_panes-check-existence-of-title-extra-field-2457995-3.patch1.61 KBb-prod
#1 fieldable_panels_panes-check-existence-of-title-extra-field-2457995-1.patch783 bytesb-prod

Comments

b-prod’s picture

b-prod commented
Status: Active » Needs review
StatusFileSize
new fieldable_panels_panes-check-existence-of-title-extra-field-2457995-1.patch783 bytes

Adds a basic check.

suldan’s picture

suldan commented

Thanks!
Applied patch #1 to 7.x-1.6-beta1+2-dev. Works for me - error message is gone.

But the the title is displayed in full view mode when it shouldn't !

b-prod’s picture

b-prod commented
StatusFileSize
new fieldable_panels_panes-check-existence-of-title-extra-field-2457995-3.patch1.61 KB

This patch takes care of some missing points for Title integration, that may cause the title to be displayed.

If you are using the Title module, do not forget to update the field display so the title replacement field is not shown on the "full" view mode.

b-prod’s picture

b-prod commented

@suldan could you tell me if this fixes your problem. If not, I would need some more details to replicate your issue...

suldan’s picture

suldan commented

@B-Prod
Applied latest patch (#3) with same effect as in #2. The field is hidden in the 'full' display, but I found the option to hide the FPP title in the field settings (under label replacement). It did the trick. I don't know if 'Hide page title' is a good label for this option, maybe something like: 'I want panels to display the FPP title'.

Anyway, thanks a lot for your effort. Problem solved for me.
suldan

b-prod’s picture

b-prod commented
Status: Needs review » Reviewed & tested by the community

@suldan the options you are speaking about are provided by the Title module.

Set as RTBC regarding to #5

  • DamienMcKenna committed f89fb41 on 7.x-1.x authored by B-Prod 
    Issue #2457995 by B-Prod: Fixed compatibility with the Title module.
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

drclaw’s picture

drclaw commented

This patch strangely never actually made it into the dev release from April 8. So, if you're using that particular development release, you'll still need to apply this patch (until the next release is rolled out in which case you can ignore this message).

Thanks! And thank you to all who helped solve this issue!
drclaw

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

@drclaw: The commit is in git but yeah, for some reason the -dev snapshot does not include it.