If I disable Module Filter, I can see dependencies, but they are hidden with it enabled.

CommentFileSizeAuthor
#8 module_filter-missing_dependencies-2457807-7.patch761 bytesgreenskin
#5 module_filter-show_dependencies-2457807-4.patch923 bytesfelribeiro
#4 module_filter-show_dependencies-2457807-4.patch997 bytesfelribeiro
modules.png56.92 KBwickss

Comments

vincentchun’s picture

vincentchun commented

Hey yeah - I just noticed this too, did a Google search and found this.
I've since discovered that if you click on the description of a module, it reveals all the version and dependency information.

greenskin’s picture

greenskin commented
Status: Active » Closed (works as designed)

#2451163: Show full description when collapsed not just one line

drupov’s picture

drupov commented
Status: Closed (works as designed) » Needs work

I think this is different than #2451163

The problem is that even if a module has dependencies they are not visible, because these dependencies can be shown only if the module has a description by clicking on the arrow left to the description (the dependencies are set to "display: none" initially).

felribeiro’s picture

felribeiro commented
StatusFileSize
new module_filter-show_dependencies-2457807-4.patch997 bytes

Verify if module has description to show the dependencies directly.

felribeiro’s picture

felribeiro commented
StatusFileSize
new module_filter-show_dependencies-2457807-4.patch923 bytes
felribeiro’s picture

felribeiro commented
Status: Needs work » Needs review

Please, review this patch.

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Reviewed & tested by the community

How to reproduce:

1. Create a module without description (or use an existent module)
2. Access module list page

Result: No dependencies are displayed for the module created above.

3. Apply patch from #5
4. Access module list page

Result: Dependencies are displayed.

RTBC.

greenskin’s picture

greenskin commented
Version: 7.x-2.0 » 7.x-2.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new module_filter-missing_dependencies-2457807-7.patch761 bytes

I think it'll be better to provide text stating the module has no description. Here's a patch that uses "No description available." as the description when the module hasn't provided one.

helmo’s picture

helmo commented
Status: Needs review » Reviewed & tested by the community

#8works good, thanks.

erickbj’s picture

erickbj commented

Confirming patch #8 works for me too.

  • greenSkin authored 068c0c1 on 7.x-2.x 
    Issue #2457807 by felribeiro, greenSkin: Module Filter not showing...
greenskin’s picture

greenskin commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone!

greenskin’s picture

greenskin commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.