Closed (fixed)
Project:
Taxonomy Menu
Version:
5.x-1.03
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Apr 2008 at 22:37 UTC
Updated:
14 Nov 2009 at 22:10 UTC
Hello:
When I installed the module I saw that is not possible override the taxonomy_term views to alter the view.
I have inspected the taxonomy_menu.inc file and I found this:
// Get the last page argument
$tid = explode('/', $_GET['q']);
$tid = db_escape_string(array_pop($tid));
$arguments[] = $vid;
// Only add the Term ID if its not the Vocabulary ID
if ($vid != $tid) {
$arguments[] = $tid;
}
// Embed the views output into the page
$output = views_build_view('embed',
views_get_view(variable_get('taxonomy_menu_show_views_'. $vid, '')),
$arguments, FALSE, NULL);
I think that this is not correct. Taxonomy terms views is expecting only one Term ID as argument. And this code is passing the Vocabulary ID and the Term ID.
Also I have seen
if ($vid != $tid) {
$arguments[] = $tid;
}
What happens if the term id is 2 and the vocabulary id is 2 too?
Well this is my small contribution.
This is a great module!
Bye
Mariano
Comments
Comment #1
arlinsandbulte commentedI am going to assume this has been fixed in later releases or is by design.....