Closed (fixed)
Project:
Flag
Version:
8.x-4.x-dev
Component:
Flag core
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Mar 2015 at 10:32 UTC
Updated:
8 Apr 2015 at 08:54 UTC
Jump to comment: Most recent
The AJAX Link Action plugin uses "AJAX Link" as plugin id. This is against best practice in core, because the plugin id is always a machine name (lowercase a-z with underscores).
Rename the plugin id.
| Comment | File | Size | Author |
|---|---|---|---|
| fix-ajax-link-annotation.patch | 654 bytes | webflo |
Comments
Comment #2
martin107 commentedI agree with the change.....
At first glance you may think the patch caused the test failures.
WITHOUT the patch applied the test fail locally for me in exactly the same way. So that is a thing.
Comment #3
joachim commentedYup, the tests are broken :(
Comment #4
martin107 commentedI created an issue for that #2455493: entity bundle caches are not correctly cleared when a flag is created sorry should have provided a link earlier
Comment #5
joachim commentedNo problem -- I saw it in the list :) I should have given the link myself in my comment; thanks for taking care of it.
Comment #9
joachim commentedTests are fixed; patch passes.
Committed!
Thanks for reporting and working on this.