Problem/Motivation

The AJAX Link Action plugin uses "AJAX Link" as plugin id. This is against best practice in core, because the plugin id is always a machine name (lowercase a-z with underscores).

Proposed resolution

Rename the plugin id.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
fix-ajax-link-annotation.patch654 byteswebflo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, fix-ajax-link-annotation.patch, failed testing.

martin107’s picture

martin107 CreditAttribution: martin107 commented

I agree with the change.....

At first glance you may think the patch caused the test failures.

WITHOUT the patch applied the test fail locally for me in exactly the same way. So that is a thing.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs work » Postponed

Yup, the tests are broken :(

martin107’s picture

martin107 CreditAttribution: martin107 commented

I created an issue for that #2455493: entity bundle caches are not correctly cleared when a flag is created sorry should have provided a link earlier

joachim’s picture

joachim CreditAttribution: joachim commented

No problem -- I saw it in the list :) I should have given the link myself in my comment; thanks for taking care of it.

Status: Postponed » Needs review

martin107 queued fix-ajax-link-annotation.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, fix-ajax-link-annotation.patch, failed testing.

Status: Needs work » Needs review

joachim queued fix-ajax-link-annotation.patch for re-testing.

joachim’s picture

joachim CreditAttribution: joachim commented
Status: Needs review » Fixed

Tests are fixed; patch passes.

Committed!

Thanks for reporting and working on this.

  • joachim committed 407bdfb on 8.x-4.x authored by webflo 
    Issue #2454557 by webflo: Fixed AJAX link plugin id to be a proper...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.