Sometimes this assertion fails on Testbot:

1st password change: bbbbbb	Other	password_policy_expiration.test	178	PasswordExpiration->testExpirationConstraint()

I suspect it is a timing problem.

CommentFileSizeAuthor
#3 password_policy-fix_intermittent_test_failure-2454501-3.patch425 bytesaohrvetpv
#1 dummy_patch_to_trigger_tests.patch511 bytesaohrvetpv

Comments

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new dummy_patch_to_trigger_tests.patch511 bytes

Let's try to reproduce the failure first.

Status: Needs review » Needs work

The last submitted patch, 1: dummy_patch_to_trigger_tests.patch, failed testing.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-fix_intermittent_test_failure-2454501-3.patch425 bytes

Reproduced. Now let's try to fix.

Hypothesis #1 is test executes so fast on Testbot that some requests after a user is blocked occur on the same second the user was blocked.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

aohrvetpv’s picture

aohrvetpv commented
Related issues: +#2455045: History entries may not be ordered correctly after rapid password changes
aohrvetpv’s picture

aohrvetpv commented
Related issues: -#2455045: History entries may not be ordered correctly after rapid password changes

Added related issue to wrong issue.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

The last submitted patch, 1: dummy_patch_to_trigger_tests.patch, failed testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 1: dummy_patch_to_trigger_tests.patch for re-testing.

AohRveTPV queued 3: password_policy-fix_intermittent_test_failure-2454501-3.patch for re-testing.

The last submitted patch, 1: dummy_patch_to_trigger_tests.patch, failed testing.

aohrvetpv’s picture

aohrvetpv commented

#3: 0/17 failures
unmodified: 3/15 failures

So it seems like #3 might fix the intermittent test failures.

  • AohRveTPV committed 4ae1039 on 7.x-1.x 
    Issue #2454501 by AohRveTPV: Intermittent expiration test failures
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.