In case instance and all the parents are empty (but some are enabled) the function returns FALSE when called with $include_defaults = TRUE. This causes metatags fieldset disappeared from the entity form in some cases. I've experienced this issue on custom module development and haven't tried to reproduce without custom code, but it's actually a general issue not specific to our custom code. Patch follows.

CommentFileSizeAuthor
#1 metatag-2454499-1.patch1.11 KBDmitriy.trt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dmitriy.trt’s picture

Dmitriy.trt CreditAttribution: Dmitriy.trt commented
Status: Active » Needs review
FileSize
metatag-2454499-1.patch1.11 KB

Instead of just converting metatag_config_load_with_defaults() to boolean, which doesn't let us to distinguish non-existing or disabled configs from empty ones, we should just look for at least one enabled config in a parents chain.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Needs review » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.