Problem/Motivation

The default Taxonomy view preview is broken.

Proposed resolution

Steps to reproduce

  1. Do a standard install.
  2. Tag some content with a taxonomy term.
  3. Be sure you can browse the tagged content at taxonomy/term/1, assuming the term you tagged is the first one.
  4. Edit the Taxonomy term view at admin/structure/views/view/taxonomy_term
  5. An 500 error is returned on the Ajax call for the preview.
  6. Type 1 in the "Preview with contextual filters" in the preview box.
  7. No content is shown in the preview.

Errors

When the view editor loads, this PHP fatal occurs:

PHP Fatal error:  Call to a member function getRouteByName() on a non-object in /Library/WebServer/Documents/drupal8x/core/modules/views/src/ViewExecutable.php on line 1818, referer: http://localhost/drupal8x/admin/structure/views/view/taxonomy_term

The browser console error is:

Uncaught AjaxError: 
An AJAX HTTP error occurred.
HTTP Result Code: 500
Debugging information follows.
Path: /drupal8x/admin/structure/views/view/taxonomy_term/preview/page_1
StatusText: Internal Server Error

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#9 taxonomy_term_view-2452659-9.patch2.23 KBcilefen
#9 taxonomy_term_view-2452659-9-test.patch770 bytescilefen
#9 interdiff-8-9.txt1.79 KBcilefen
#8 taxonomy_term_view-2452659-8.patch1.47 KBcilefen
#8 interdiff-6-8.txt675 bytescilefen
#6 taxonomy_term_view-2452659-6.patch712 bytescilefen
#5 taxonomy_term_view-2452659-5.patch1.35 KBcilefen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Title: Contextual filters don't work in Taxonomy term View preview » Taxonomy term View preview is broken
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Issue summary: View changes
cilefen’s picture

cilefen CreditAttribution: cilefen commented

The problem is that ViewExecutable::routeProvider has not been set in this case.

Line 1818

    /** @var \Drupal\Core\Url $url */
    $url = $display_handler->getUrlInfo();
    $route = $this->routeProvider->getRouteByName($url->getRouteName());
cilefen’s picture

cilefen CreditAttribution: cilefen commented
Priority: Normal » Major
Status: Active » Needs review
FileSize
taxonomy_term_view-2452659-5.patch1.35 KB

In this patch, I save the route provider before $executable is destroyed, then re-set it.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
FileSize
taxonomy_term_view-2452659-6.patch712 bytes

Here is a simpler way to get the same result: Do not strip the routeProvider from ViewExecutable when it is destroyed.

Status: Needs review » Needs work

The last submitted patch, 6: taxonomy_term_view-2452659-6.patch, failed testing.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs work » Needs review
FileSize
interdiff-6-8.txt675 bytes
taxonomy_term_view-2452659-8.patch1.47 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented
FileSize
interdiff-8-9.txt1.79 KB
taxonomy_term_view-2452659-9-test.patch770 bytes
taxonomy_term_view-2452659-9.patch2.23 KB

The last submitted patch, 9: taxonomy_term_view-2452659-9-test.patch, failed testing.

olli’s picture

olli CreditAttribution: olli commented
Issue tags: +VDC
Parent issue: » #2409209: Replace all _url() calls beside the one in _l()
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Good point!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 261e709 on 8.0.x 
    Issue #2452659 by cilefen: Taxonomy term View preview is broken

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.