Translation settings don't appear for node in standard.

The fix seems to make sense to me. Let's send this for testing for a start.

Yep, checking entity type translatability should be enough, given that's what will trigger the creation of data tables.

Doing that then :)

Was looking into providing test coverage, but could not reproduce the bug and not sure why. I installed Standard, enabled Language module and added another language. I cannot see the language option in the file view but can see in node and user views. I also created a view of custom blocks, can see the language option there too.

I can see how the code does not make sense, but cannot reproduce a scenario where it would fail... Also, the isTranslatable() is a property of the entity type (does not require content translation module to set any translatability). Not sure if we want to tie this to ACTUAL translatability (ie. configured to be translatable) or theoretical translatability (can be configured to be translatable). It is currently the later. If its not currently configured to be translatable, then it should not have translations normally.

@dawehner or @plach: Can you help me with steps to reproduce?

So I could not reproduce because I was using beta7. Using HEAD I can reproduce. Found that this is due to http://cgit.drupalcode.org/drupal/commit/core/modules/views/src/Plugin/v... via #2429447: Use data table as views base table, if available..

Working on tests.

Patch looks good, setting to NW for tests...

1. Made the popup handler use the same condition (multilingual & translatable) that the display overview used.
2. Fixed the information message that shows for the case when the feature is not supported. It depends on the view itself not if generally the user has translatable entity types or not.
3. Added tests for various stages of enabling multilingual and how that changes (or not) whether the view supports it.

Note that the test-only patch has the textual fix so it does not fail on that :)

assertTranslationSetting() => checkTranslationSetting() to make it easier to debug. Suggestion from @dawehner on IRC.

I'm going to have a look at this right now.

This should do it.

Oops, that interdiff was correct but the actual patch wasn't :/. One more try.

Trivial fix compared to #12, so should be back to RTBC. Thanks!

git ac https://www.drupal.org/files/issues/2450205-18.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5562  100  5562    0     0  18556      0 --:--:-- --:--:-- --:--:-- 20152
error: patch failed: core/modules/views/src/Plugin/views/display/DisplayPluginBase.php:2610
error: core/modules/views/src/Plugin/views/display/DisplayPluginBase.php: patch does not apply

Rerolled

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed a805ce2 and pushed to 8.0.x. Thanks!

Yay, thanks all!