Problem/Motivation
The wording for the description of Show all restrictions on password change page setting is not clear, and not formal enough.
The description:
Should password restrictions be listed on the password change page. A javascript warning block will be shown anyways if ithe typed in password does not meet the restrictions.
Steps to reproduce the bug:
- click Administration
- click Configuration
- click People
- click Password policies
- scroll down to Visibility settings box
Proposed resolution
Change the description of Show all restrictions on password change page setting to
List all password restrictions on the password change page. The list is displayed in addition to the default dynamic, JavaScript-generated list of only the restrictions the typed password does not meet. Enabling this setting allows a user who is not using JavaScript to see the password restrictions prior to submitting their password.
Remaining tasks
- Commit
User interface changes
Show all restrictions on password change page setting's description changed to
List all password restrictions on the password change page. The list is displayed in addition to the default dynamic, JavaScript-generated list of only the restrictions the typed password does not meet. Enabling this setting allows a user who is not using JavaScript to see the password restrictions prior to submitting their password.
API changes
none
Original report by [AohRveTPV]
1. Typo "ithe"
2. "anyways" is colloquial
3. Wording is unclear because password restrictions are listed on the password change page already by JavaScript. So an administrator may wonder what the purpose of this setting is. The purpose is to provide a static list of all restrictions, in addition to the dynamic JavaScript list of restrictions. This wording attempts to clarify.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | password_policy-improve_show_restrictions_wording-2449343-3.patch | 1.13 KB | aohrvetpv |
Comments
Comment #1
aohrvetpv commentedComment #2
aohrvetpv commentedLike the wording in this patch a bit better.
Comment #3
aohrvetpv commentedTried to clarify setting title wording too.
Comment #4
banviktor commentedIssue reviewed, summary updated.
The patch works and has no errors.
As I'm not an experienced Drupal developer I won't set it to RTBC, but I think it is good to go.
Comment #5
aohrvetpv commentedThanks for reviewing it, banviktor. I will give a little more time for others to possibly review before committing.
Comment #8
aohrvetpv commentedSuspected timing bug unrelated to this patch.
Comment #10
aohrvetpv commentedComment #13
aohrvetpv commentedThis setting does not exist in 7.x-2.x.