Problem/Motivation

The wording for the description of Show all restrictions on password change page setting is not clear, and not formal enough.

The description:

Should password restrictions be listed on the password change page. A javascript warning block will be shown anyways if ithe typed in password does not meet the restrictions.

Steps to reproduce the bug:

  1. click Administration
  2. click Configuration
  3. click People
  4. click Password policies
  5. scroll down to Visibility settings box

Proposed resolution

Change the description of Show all restrictions on password change page setting to

List all password restrictions on the password change page. The list is displayed in addition to the default dynamic, JavaScript-generated list of only the restrictions the typed password does not meet. Enabling this setting allows a user who is not using JavaScript to see the password restrictions prior to submitting their password.

Remaining tasks

  1. Commit

User interface changes

Show all restrictions on password change page setting's description changed to

List all password restrictions on the password change page. The list is displayed in addition to the default dynamic, JavaScript-generated list of only the restrictions the typed password does not meet. Enabling this setting allows a user who is not using JavaScript to see the password restrictions prior to submitting their password.

API changes

none

Original report by [AohRveTPV]

1. Typo "ithe"
2. "anyways" is colloquial
3. Wording is unclear because password restrictions are listed on the password change page already by JavaScript. So an administrator may wonder what the purpose of this setting is. The purpose is to provide a static list of all restrictions, in addition to the dynamic JavaScript list of restrictions. This wording attempts to clarify.

Comments

aohrvetpv’s picture

Status: Active » Needs review
StatusFileSize
new1000 bytes
aohrvetpv’s picture

StatusFileSize
new1009 bytes

Like the wording in this patch a bit better.

aohrvetpv’s picture

StatusFileSize
new1.13 KB

Tried to clarify setting title wording too.

banviktor’s picture

Issue summary: View changes

Issue reviewed, summary updated.
The patch works and has no errors.

As I'm not an experienced Drupal developer I won't set it to RTBC, but I think it is good to go.

aohrvetpv’s picture

Thanks for reviewing it, banviktor. I will give a little more time for others to possibly review before committing.

Status: Needs review » Needs work
aohrvetpv’s picture

Suspected timing bug unrelated to this patch.

Status: Needs work » Needs review
aohrvetpv’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

  • AohRveTPV committed bcdc9b5 on 7.x-1.x
    Issue #2449343 by AohRveTPV, banviktor: Wording of "Show restrictions on...

  • AohRveTPV committed b920521 on 6.x-1.x
    Issue #2449343 by AohRveTPV, banviktor: Wording of "Show restrictions on...
aohrvetpv’s picture

Status: Patch (to be ported) » Fixed

This setting does not exist in 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.