Panels exports include extra indentation where it doesn't match Drupal coding standards. For example:

  $display->panels = array();
    $pane = new stdClass();
    $pane->pid = 'new-36405db8-54c5-495c-ba8a-0a5f7ade185a';

Notice how $display is prefixed with 2 spaces, but $pane is prefixed with 4 spaces. There is no reason for the additional indentation!

This creates problems with using Features to export Panels pages (or Panelizer defaults or Mini-panels) and tools to automatically test coding standards - it generates lots of false positives.

I'll attach a patch to fix in a moment.

Files: 
CommentFileSizeAuthor
#1 panels-export-indentation-2448825-1.patch1.02 KBdsnopek
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Comments

dsnopek’s picture

Title: Wrong identation in Panels exports » Wrong indentation in Panels exports
Status: Active » Needs review
FileSize
1.02 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

Patch is attached!

rodrigoaguilera’s picture

Status: Needs review » Reviewed & tested by the community

Works as expected.

Thanks!

rvilar’s picture

Tested and works as expected. Tanks!

japerry’s picture

Status: Reviewed & tested by the community » Fixed

Done. Fixed!

  • japerry committed 34cec08 on 7.x-3.x authored by dsnopek
    Issue #2448825 by dsnopek: Wrong indentation in Panels exports
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.