That's a quite common case that theme layout has not right place for Masquerade block, especially at development time. Therefore default admin theme (Seven) is built without sidebars and the block is forced to be in main content region. I propose attaching a simple floating button for masquerading / unmasquerading.

CommentFileSizeAuthor
#6 2448271-6.patch547 bytesandypost
#6 masquerade_menu.png5.74 KBandypost
#5 masquerade-modal.gif67.63 KBChi
#3 masquerade-ui_improvement-2448271-2.patch3.79 KBChi
#1 masquerade-ui_improvement-2448271-0.patch3.77 KBChi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Active » Needs review
FileSize
masquerade-ui_improvement-2448271-0.patch3.77 KB

Status: Needs review » Needs work

The last submitted patch, 1: masquerade-ui_improvement-2448271-0.patch, failed testing.

Chi’s picture

Chi CreditAttribution: Chi commented
Status: Needs work » Needs review
FileSize
masquerade-ui_improvement-2448271-2.patch3.79 KB

Cleanup

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue tags: +Needs screenshots

Thanx for idea, technical implementation suppose should be a bit different
This approach solves at last current regression of absence unmasquerade link (seems menu changes)

Also I thought about svg icon for right area of toolbar but toolbar is not enabled for authenticated users in standard profile so we need default menu link in any standard menus.
Having a dialog form to masquerade require to add setting for redirect or front route because modal have no referer to redirect

Chi’s picture

Chi CreditAttribution: Chi commented
Issue tags: -Needs screenshots
FileSize
masquerade-modal.gif67.63 KB

so we need default menu link in any standard menus

Many sites do not use standard menus.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
masquerade_menu.png5.74 KB
2448271-6.patch547 bytes

Take a loot at comment and user module *.links.menu.yml files they provide links for standard profile. I just can't get why access for them is not checked right now

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented
Related issues: +#2463659: Regression test coverage: integration test for an uncacheable menu link that depends on session data, +#1805054: Cache localized, access filtered, URL resolved, and rendered menu trees

So, #6 is answered by #2463659: Regression test coverage: integration test for an uncacheable menu link that depends on session data, and is fixed by #1805054: Cache localized, access filtered, URL resolved, and rendered menu trees. Access now is correctly checked, even when menu blocks are render cached.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented

It makes sense to use the same approach as \Drupal\user\Plugin\Menu\LoginLogoutMenuLink does in core now

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers as a volunteer commented

That makes sense :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Needs review » Postponed
Parent issue: » #2695779: Unmasquerade link appears for users with the permission: 'link to any page', regardless of masquerade status.

Postponed on #2695779: Unmasquerade link appears for users with the permission: 'link to any page', regardless of masquerade status.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Postponed » Active
Parent issue: #2695779: Unmasquerade link appears for users with the permission: 'link to any page', regardless of masquerade status. » #2982514: Masquerade 8.x-2.0 stable release plan