Problem/Motivation

core/modules/toolbar/css/toolbar.module.css contains this line:

.toolar .toolbar-tray > .toolbar-lining {

Emphasis on the "toolar".

Proposed resolution

This line was introduced as .toolar .tray .lining in #1137920: Fix toolbar on small screen sizes and redesign toolbar for desktop and was initially committed in November 2012. It can probably be removed, but we might as well see if it's doing anything I suppose :)

The line was changed most recently in #1938044: Prefix all toolbar classes to prevent theme clashes and then earlier in #1847314: Reduce the dependency on JavaScript for the toolbar to display properly (thanks recursive-blame)

Remaining tasks

  • Patch
  • Review
  • Screenshots potentially

User interface changes

TBD

API changes

n/a

CommentFileSizeAuthor
#1 drupal-toolbarmodulecss-2448023-1.patch527 bytesanksy

Comments

anksy’s picture

StatusFileSize
new527 bytes

I don't think it does anything.Can't find anything being influenced by it. Here's the patch.

anksy’s picture

Status: Active » Needs review
star-szr’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Updating the issue summary to correct an inaccuracy, the line has been changed a couple times. I did some testing across a handful of browsers (IE9, Firefox, Chrome, Safari) and found that correcting this typo did not change anything in either vertical or horizontal orientation so I agree this is safe to remove.

Thanks @anksy!

star-szr’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: +Quick fix
star-szr’s picture

Status: Needs review » Reviewed & tested by the community

Phone decided it was CNR apparently ;)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

bye bye toolar. Committed 8429258 and pushed to 8.0.x. Thanks!

  • alexpott committed 8429258 on 8.0.x
    Issue #2448023 by anksy: Fix or remove dead CSS in toolbar.module.css
    
hass’s picture

Project: Drupal core » Navbar
Version: 8.0.x-dev » 7.x-1.x-dev
Component: toolbar.module » Code
Status: Fixed » Patch (to be ported)

  • eshta committed d6ed0b3 on
    Issue #2448023 by eshta: Remove unused CSS.
    
eshta’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.