Fix fork feature

Forgot to change issue status

Why one result? I don't know as the db_query_range was not implemented correctly. It's a quick fix.

Yeah a lot of things to do, that's why I have proposed to delete if nobody is using it.

Ok about keeping the feature if we have tests for it.

Hello,

There is a patch that fix the fork feature and add tests for that.

@izus: Now I can answer you why one result. Because it is the node to which the user will be redirected.

Thanks for the review.

Hum I don't understand why the tests failed with the automated bot and not in my ocal environment.

If someone can test the last patch please.

Thanks for the tests Izus.

To help debugging the do automated tests, would it be better to merge the patch commenting the test that does not pass so it will be easier to review small patches ?

Ok, this is now merged.

I suspect that it is the function to clear user session that does not work on the testbot. Let's see that.

I don't understand why it is failing.

As said on: https://www.drupal.org/project/testbot

I test on simplytest.me, I test using the command line, I test without url rewriting. Each time it is ok.

And this is not a problem of clearing the session because there is a test on clearing session in protected_node.bulk.test and it is ok.

Hum... Maybe it is the way to format the URL of $this->drupalPost('protected-nodes', $form, t('OK'), array('query' => array('protected_pages' => $protected_pages)));

with $protected_pages = implode(',', array($node1->nid, $node2->nid));

Maybe on testbot the second nid is not well detected. I think of an improvement, in the function protected_node_get_nids_from_protected_pages_parameter() instead of manipulating $_GET, using the function drupal_get_query_parameters.

I will try that.

Ok That is not the problem.

I will try creating another user to access the second node in the test.

sending patch to testbot

Hello,

It is already merged.

Yeah, I know you had those problems :), like you I will try using xpath to know what the testbot landing page looks like.

If that did not success, maybe I will post an issue on the testbot project.

With that patch, we will know the title of the falling page.

Ok, so the user is on the password form. Let's see if it is in error.

1. +++ b/tests/protected_node.fork.test
   @@ -109,10 +108,15 @@ class ProtectedNodeFork extends ProtectedNodeBaseTestCase {
   +    $this->assertEqual($title, $page_title, "Node title: $title. Xpath found title: $page_title.", $this->group);
   

   So this time this assertion is green.

2. +++ b/tests/protected_node.fork.test
   @@ -109,10 +108,15 @@ class ProtectedNodeFork extends ProtectedNodeBaseTestCase {
   +    $this->assertText('Incorrect password!', "the user has entered the wrong password", $this->group);
   

   But this one is not. So The user has arrived to the node2 page. Whereas in the previous patch he/she can't... Strange.

This time as previously the user has arrived to node 2. The tests should be green.

Ah! the test is green has predicted.

So with the same tests, one time the testbot returns red and the other time it is green... I don't know how to be sure we can trust the testbot.

Hello,

Thanks for the suggestion. I will try with Drupal installed as a subfolder.

But I don't want to spend more time on this because I think (hope) it will be solved with the new Drupal CI that will replace the testbot.

Hello,

The tests are green in local even with Drupal accessed as a subfolder.

Hello,

I consider the issue fixed. The problem with the test should fixed in https://www.drupal.org/node/2277045#comment-10092654

Thanks.

Hello,

Thanks for the feedback. For me locally it works everytime (I need to check). Could you please give your configuration?

Now every tests pass... Very very strange. I think I am becoming crazy...