Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SebCorbin’s picture

DamienMcKenna’s picture

Status: Active » Needs review

Thanks for the patch, we'll try to review it soon.

BTW when you upload a patch it helps to set the status to "needs review", that triggers the testbots and lets others know that there's something review.

steinmb’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
2.88 KB

Patch no longer apply.

git apply -v performance_replace-2447277-1.patch
Checking patch date.field.inc...
error: while searching for:
 *     start date and the repeat rule will be displayed.
 */
function date_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  $element = array();
  $settings = $display['settings'];
  $formatter = $display['type'];
  $variables = array(

error: patch failed: date.field.inc:113
error: date.field.inc: patch does not apply

Manually re-rolled. Seems to work just fine.

DamienMcKenna’s picture

This looks good, thanks.

  • DamienMcKenna committed 6511413 on 7.x-2.x authored by steinmb
    Issue #2447277 by SebCorbin, steinmb: Performance: replace sylesheets[...
DamienMcKenna’s picture

Component: Miscellaneous » Code
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

m.stenta’s picture

This change seems to have missed some places where `date_api/data.css` is needed. See new issue: #3067396: Date CSS not added for all Form API elements