MailChimp Lists currently sends (or queues for sending) subscription information using hook_field_presave().
This is really too early in the process and hook_field_insert()/hook_field_update() would be the better place to perform this action.
Specifically things that don't work with the current approach:
hook_field_presave() in any module that would normally preceed it (by weight/name)hook_entity_presave() as this is done after field hooks.I'm not sure if there was a particular reason for doing it in hook_field_presave()?
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2445867-3-dont_use_hook_field_presave.patch | 1.46 KB | andrewbelcher |
| #1 | 2445867-1-dont_use_hook_field_presave.patch | 1.46 KB | andrewbelcher |
Comments
Comment #1
andrewbelcher commentedHere's a patch that does it.
Comment #2
Anonymous (not verified) commentedHi,
Moving to the postsave hook is an interesting idea and we'll test it out, but we're not sure what the plan was in this patch, with the presave and update hook implementations calling the postsave hook. At first blush, it seems like just changing "pre" to "post" in the function name would be enough.
Thanks!
Comment #3
andrewbelcher commentedApologies, the patch was slightly wrong. It was supposed to be
hook_field_insert()andhook_field_update().There isn't a
hook_field_postsave(), but rather the 2 separate ones for insert/update, so that's why the postsave is a separate function.Comment #4
Anonymous (not verified) commentedAh, that makes sense. Thanks for the clarification and the updated patch; I'll test this out.
Comment #6
Anonymous (not verified) commented