Needs to be solved. Currently showing with newest dev of draggableviews and newest stable version of views.

CommentFileSizeAuthor
#1 notice_undefined-2445787-1.patch975 bytespmchristensen

Comments

pmchristensen’s picture

pmchristensen commented
Status: Active » Needs review
StatusFileSize
new notice_undefined-2445787-1.patch975 bytes

Solved with the following patch.

istryker’s picture

istryker commented

Do you know why you are getting the error and how you patch fixes it?

What version of PHP are you running?

pmchristensen’s picture

pmchristensen commented

Well the notice is comming because it loops through this twice, once with the value set to "flag_bookmarks:page" in $view->sort[$weight_key]->options['draggableviews_setting_view'] and the second time with the value set to "self", which fails because the following is run against the value list($setting_view_name, $setting_view_display) = explode(':', $view->sort[$weight_key]->options['draggableviews_setting_view']);

So it looks like a problem between draggableviews and the flag module. Have installed the latest stable version of the flag module.

istryker’s picture

istryker commented

Can you test #2413433: update 'self' sort handler setting in db patch and see if that works. I believe that get rid of the self in the database.

istryker’s picture

istryker commented

Sorry. Forget #2413433: update 'self' sort handler setting in db and test #2413429: always provide sort options . Patch #5 in #2413429 gets rid of the if statement completely.

acrosman’s picture

acrosman
Primary language English
Location South Carolina, US
commented

I'm seeing the same notice after updating to the current release version. Patch #5 in #2413429 did not resolve it. Patch #1 here doesn't apply cleanly for me to the current release (which obviously may not be a problem really). I'll try it against the dev.

acrosman’s picture

acrosman
Primary language English
Location South Carolina, US
commented

Patch #1 applied cleanly against dev, and clears the notice.

pglatz’s picture

pglatz commented

Same problem - using PHP 5.4.34, dev from 5/6/15. Have applied patch #1, and when I do, get no results from the view.

sonicthoughts’s picture

sonicthoughts commented

I see this issue but do not have flag module enabled (it is installed however).

istryker’s picture

istryker commented
Status: Needs review » Needs work

Needs reroll

wayne.gormont’s picture

wayne.gormont commented

What solved this issue for me was to change the field "Draggableviews: Weight" under Sort Criteria on Argument Handling from "Do not use any arguments (use empty arguments)" to " Use all arguments".

simohell’s picture

simohell commented

#11 got rid of the errors. Didn't check for side effects yet...

pglatz’s picture

pglatz commented

Just updated from 7.x-2.0 to 7.x-2.1, getting the same problem:

Undefined offset: 1 in draggableviews_join_handler->build_join() line 50

jldust’s picture

jldust commented

This issue is still occurring, did we narrow down the problem?

bhushan.nagaonkar’s picture

bhushan.nagaonkar commented

issue still occuring, getting notices Undefined offset: 1 in draggableviews_join_handler->build_join() line 50

ed2908’s picture

ed2908 commented

I'm seeing this as well on 7.x-2.1 using core 7.89, no flag module installed, every view block set to use all arguments.