Use Radix as installer theme [#2445359]

Separating out the task of using Radix as the installer theme from #1987386: Include Radix theme in Panopoly so we don't hold up that ticket.

I tested Radix 3.0-rc2 as the installer theme using patch from here and noticed several issues. I've attached a few screenshots from the install process. Some quick observations...

Logo / title spacing
Module install page not themed
Forms look ok
Missing install steps on left side
Theme selection radio button alignment
Radix theme not default selected

Comment	File	Size	Author
#14	Panopoly+Radix+Install.png	95.75 KB	shadcn
#12	use_radix_as_installer-2445359-12.patch	1.15 KB	cornifex
#10	use_radix_as_installer-2445359-10.patch	1.18 KB	cornifex
#5	use_radix_as_installer-2445359-5.patch	903 bytes	cornifex
#3	use_radix_as_installer-2445359-3.patch	1.02 KB	cornifex
#1	panopoly_radix_installer_6.jpg	70.82 KB	caschbre
	panopoly_radix_installer_5.jpg	86.83 KB	caschbre
	panopoly_radix_installer_4.jpg	121.23 KB	caschbre
	panopoly_radix_installer_3.jpg	79.04 KB	caschbre
	panopoly_radix_installer_2.jpg	30.05 KB	caschbre
	panopoly_radix_installer_1.jpg	47.12 KB	caschbre

Comments

Comment #1

caschbre commented 3 March 2015 at 20:28

Status	File	Size
new	panopoly_radix_installer_6.jpg	70.82 KB

Comment #2

caschbre commented 3 March 2015 at 20:29

1 file was hidden/shown/deleted

Status	File	Size
hidden	panopoly_radix_installer_4.jpg	121.23 KB

Hmm... can only display 5 images... removing one that doesn't show much.

Comment #3

cornifex commented 7 March 2015 at 19:51

Status:

Active

» Needs review

Status	File	Size
new	use_radix_as_installer-2445359-3.patch	1.02 KB

Added a patch that sets Radix as installer theme.

Comment #4

mglaman

English

WI, USA

commented 7 March 2015 at 20:08

Status:

Needs review

» Needs work

Bad patch, use git.

Status	File	Size
new	use_radix_as_installer-2445359-5.patch	903 bytes

Comment #6

mglaman

English

WI, USA

commented 7 March 2015 at 20:21

1 file was hidden/shown/deleted

Status	File	Size
hidden	use_radix_as_installer-2445359-3.patch	1.02 KB

So #5 is RTBC so setup installer. Just need Radix fixes.

Comment #7

cornifex commented 7 March 2015 at 21:24

To go even a little more in depth, the Panopoly logo is set in css as a background image on #logo. The logo should be set as normal in an img tag. I've set the logo path locally, during install with the following in panopoly.profile, but the logo will still need to be dropped in the Radix template:

/**
 * Implements hook_preprocess_maintenance_page.
 */
function panopoly_preprocess_maintenance_page(&$variables) {
  if (drupal_installation_attempted()) {
    $variables['logo'] = drupal_get_path('profile', 'panopoly') . '/panopoly.png';
  }
}