We're still on a Git revision (6382429) between 2.0-alpha3 and 2.0-alpha4. We should update to 2.0-alpha4 and fix any regressions/issues. Here's the release notes for it:
https://www.drupal.org/node/2350473
The diff between our current revision and 2.0-alpha4 is actually only 763 lines, so the changes aren't that big. I counted only 18 commits.
This also includes a possible fix to one of the issues that prevents us from upgrading jquery_update (the Media browser appearing under the CTools modal):
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | panopoly_widgets-media-2.0-alpha4-2445119-2.patch | 1.75 KB | dsnopek |
Comments
Comment #1
mglamanFor what it's worth - we're using alpha4 for 2 releases now without issues on the Panopoly stack.
We did have a few issues at first. See #2194821: Embedded media objects should honor display suite settings. Here's a link to my method of fixing it https://gist.github.com/mglaman/f9460f9c1bd6bf230dd5.
It also relates to #2367725: Max nesting level reached due media_wysiwyg_token_to_markup() & view mode "full"
If getting Panopoly up to speed requires getting a configurable setting in #2194821 to toggle "Full template or WYSIWYG rendering" whatever it may be, I'll get that whipped up in a heartbeat (like at the sprint!)
Comment #2
dsnopekHere's a patch that simply updates the .make file. It works pretty good in my testing!
@mglaman: Can you explain why the fix you linked to is necessary? I understand that the markup will change because of that issue, but what are steps to see the negative affects of that? I've inserted a bunch of images and everything seems fine...
EDIT: Here's a Travis build of this patch: https://travis-ci.org/panopoly/panopoly/builds/63327310
Comment #3
dsnopekEr, actually, it looks like #2194821: Embedded media objects should honor display suite settings isn't in Media 2.0-alpha4! That got merged 4 days after -alpha4 was released. So, well need to worry about that issue when we do the next update (if it isn't fixed by then) but not now, which makes me feel a little safer about this update. :-)
Comment #4
mglamanYou're right, it isn't in alpha4. I think alpha4 is a safe upgrade then. The display suite commit just adds more markup and can affect how you've expected items to appear in the body's WYSIWYG like for RWD styling of images.
With this bump we can include my patch for multiselect support.
Comment #5
dsnopekAutomated and manual testing looks good! Committed, finally. :-)
Comment #8
chrisgross commentedUpdating Panopoly to 1.22 made this issue appear: https://www.drupal.org/node/1974774.
Reverting the media module to the version used in 1.21, did not fix the issue, so it seems that something is wrong in one of the Panopoly modules.
Comment #9
dsnopek@chrisgross: Thanks for the bug report! Can you open a new issue? This issue was about updating to Media 2.0-alpha4, which has already been done (and appears from your comment to not be related to the bug). Thanks!