Closed (fixed)
Project:
Entity Email
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
3 Mar 2015 at 09:40 UTC
Updated:
19 Dec 2018 at 05:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mkolar commentedI also see the Undefined index notices:
Notice: Undefined index: mail_bcc in entity_email_create() (line 344 of /.../sites/all/modules/contrib/entity_email/entity_email.module).
Notice: Undefined index: mail_cc in entity_email_create() (line 347 of /.../sites/all/modules/contrib/entity_email/entity_email.module).
Comment #2
mkolar commentedComment #3
mkolar commentedHere is the patch file...
Comment #4
mkolar commentedLooks like you didn't use unix line endings so the path don't want to apply through drush make. You should use unix line endings. Here is path with windows endings.
Comment #5
mkolar commentedComment #8
mkolar commentedTests died because Windows line endings..
Comment #11
mojzis commentedresubmitting with unix line ends in the patch :)
Comment #12
mojzis commentedComment #14
mkolar commentedPatch against latest 7.x branch
Comment #15
mkolar commentedComment #17
mkolar commentedHonestly I don't know what's wrong now.. I didn't find anything useful in log.
Comment #20
yepaAnother patch based on 7.x-1.x (dev version)
Comment #21
yepaComment #22
yepaComment #24
yepapatch based on 7.x-1.3
Comment #25
yepaComment #27
yepaComment #29
yepaAfter clone entity email with this command on linux system :
git clone --branch 7.x-1.3 http://git.drupal.org/project/entity_email.git
I have files with crlf (windows line end).
I tried on another project like entity (no CRLF)...
Comment #30
mkolar commentedHi, there have to be some other problem probably with tests, because patch #14 is against latest and there is no windows line endings..
Comment #31
mojzis commentedinteresting ... was this : https://www.drupal.org/node/2445071 merged to 1.3 then ?
Comment #32
David Hernández commentedJust rerolling the patch from #14:
I created a new patch, also removing all the trailing whitespaces of the module itself to comply with the Drupal Code standards.
This patch is almost like the one from #14, but hopefully will be applied now, as the windows line endings have been removed from the code and the patch.
Comment #33
David Hernández commentedThe testbot has marked the last patch as posponed because the current dev branch has the tests broken: https://qa.drupal.org/pifr/test/615393
Comment #35
mkolar commentedShould we create an issue about failing tests?
Comment #36
mojzis commentedits there :) #2466537: Tests are broken
Comment #37
mkolar commentedComment #38
Anonymous (not verified) commentedPatch #14 cleans the CC and BCC messages, thanks
Comment #40
chris burge commentedComment #41
chris burge commented