Saving language translation fatals when a bundle with no bundle types exists [#2444507]

Not sure if this is a bug with Language module or upstream or that but the issue occurs when attempting to save languages.

Steps to recreate
* Miminal install
* Enable comment module and don't set up any comment types
* Enable language and set up new language say en-us
* Enable content translation
* Goto http://localhost/en-us/admin/config/regional/content-language
* Hit save

The following error is shown
LogicException: Missing bundle entity, entity type comment_type, entity id comment. in Drupal\language\Entity\ContentLanguageSettings->calculateDependencies() (line 203 of core\modules\language\src\Entity\ContentLanguageSettings.php).

This is because bundle_of is not set for the comment entity and as such a none existent bundle type loaded and the depedency check fails.

Comment	File	Size	Author
#9	6-9-interdiff.txt	822 bytes	hchonov
#9	2444507-9.patch	2.29 KB	hchonov
#9	8.0.x: PHP 5.5 & MySQL 5.5 13,995 pass
#6	2444507-fix_with_test.patch	2.29 KB	hchonov
#6	8.0.x: PHP 5.5 & MySQL 5.5 13,872 pass
#2	2444507-fatal-test.patch	1.42 KB	marcingy
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan commented 2 March 2015 at 20:08

Priority:	Critical	» Major
Issue tags:		+Needs tests

Thanks

Comment #2

marcingy CreditAttribution: marcingy commented 5 March 2015 at 23:17

Status:

Active

» Needs review

File	Size
2444507-fatal-test.patch	1.42 KB

Here is a test that fails for the issue

Comment #3

5 March 2015 at 23:34

Status:

Needs review

» Needs work

The last submitted patch, 2: 2444507-fatal-test.patch, failed testing.

Comment #4

Sutharsan CreditAttribution: Sutharsan commented 8 March 2015 at 20:45

Issue tags:

-Needs tests

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost as a volunteer and at Skilld commented 19 September 2015 at 13:00

Issue tags:

+language-content

Comment #6

hchonov

Bulgarian

🇪🇺🇩🇪🇧🇬

CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented 19 September 2015 at 18:01

Status:

Needs work

» Needs review

File	Size
2444507-fix_with_test.patch	2.29 KB
8.0.x: PHP 5.5 & MySQL 5.5 13,872 pass

Fix + test.

Comment #7

hchonov

Bulgarian

🇪🇺🇩🇪🇧🇬

CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented 20 September 2015 at 09:27

Issue tags:

+sprint

Comment #8

penyaskito

he/him

Spanish

🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺

CreditAttribution: penyaskito at Lingotek commented 26 September 2015 at 09:50

+++ b/core/lib/Drupal/Core/Entity/EntityType.php
@@ -796,7 +796,7 @@ public function addConstraint($constraint_name, $options = NULL) {
-    if ($bundle_entity_type_id = $this->getBundleEntityType()) {
+    if ($bundle != $this->getProvider() && $bundle_entity_type_id = $this->getBundleEntityType()) {

AFAIK getProvider() does return the module name, and a module can provide entities with a different name than the module itself. Should we compare to entity_type_id instead?

Comment #9

hchonov

Bulgarian

🇪🇺🇩🇪🇧🇬

CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented 26 September 2015 at 12:43

File	Size
2444507-9.patch	2.29 KB
8.0.x: PHP 5.5 & MySQL 5.5 13,995 pass
6-9-interdiff.txt	822 bytes

@penyaskito++:
Thanks! You are right of course. I missed that one....

Comment #10

hchonov

Bulgarian

🇪🇺🇩🇪🇧🇬

CreditAttribution: hchonov at bio.logis Genetic Information Management GmbH commented 26 September 2015 at 16:03

3 files were hidden/shown/deleted

File	Size
2444507-fatal-test.patch	1.42 KB

2444507-fix_with_test.patch	2.29 KB
8.0.x: PHP 5.5 & MySQL 5.5 13,872 pass
6-9-interdiff.txt	822 bytes

Comment #11

penyaskito

he/him

Spanish

🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺

CreditAttribution: penyaskito at Lingotek commented 27 September 2015 at 09:47

Status:

Needs review

» Needs work

+++ b/core/lib/Drupal/Core/Entity/EntityType.php
@@ -796,7 +796,7 @@ public function addConstraint($constraint_name, $options = NULL) {
+    if ($bundle != $this->id() && $bundle_entity_type_id = $this->getBundleEntityType()) {

Nitpick: !==

+++ b/core/modules/content_translation/src/Tests/ContentTranslationSettingsBundlesTest.php
@@ -0,0 +1,41 @@
+  /**
+   * Tests that the settings UI saves when no bundles exist.
+   */
+  function testSettingsUI() {
+    $this->drupalPostForm('admin/config/regional/content-language', array(), t('Save configuration'));
+  }

Can we at least assert the message shown when it is successfully saved?

Comment #12

plach

he/him

Italian

Venezia

CreditAttribution: plach as a volunteer commented 22 November 2015 at 23:32

Status:	Needs work	» Closed (duplicate)
Related issues:		+#1919468: EntityManager::getAllBundleInfo() adds default entity_type_id bundle for entity types with bundles

I think this is a duplicate of #1919468: EntityManager::getAllBundleInfo() adds default entity_type_id bundle for entity types with bundles, please reopen if this is not fixed in 8.0.0 and following.