Hello,

I have the need to allow of an expiration email subject of more than 128 characters (cause of tokens).

I will upload a patch soon.

CommentFileSizeAuthor
#4 password_policy-extend_maxlength_email_subject-2444433-4.patch882 bytesgrimreaper
#1 password_policy-extend_expiration_email_subject-2444433-1.patch881 bytesgrimreaper

Comments

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new password_policy-extend_expiration_email_subject-2444433-1.patch881 bytes
aohrvetpv’s picture

aohrvetpv commented
Title: Extending maxlenght of expiration email subject » Extending maxlength of expiration email subject
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Postponed (maintainer needs more info)

Would 180 work? 7.x-1.x and 6.x-1.x use maxlength 180. I think it'd be good to be consistent if possible.

Thanks for the patch.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new password_policy-extend_maxlength_email_subject-2444433-4.patch882 bytes

Hello,

No problem, my subject was about 150 characters.

Here is the patch with 180 characters.

Thanks for the review :)

aohrvetpv’s picture

aohrvetpv commented

Changing issue subject for commit message.

aohrvetpv’s picture

aohrvetpv commented
Title: Extending maxlength of expiration email subject » Extend maxlength of expiration email subject

  • AohRveTPV committed a06bd4f on 7.x-2.x authored by Grimreaper 
    Issue #2444433 by Grimreaper: Extend maxlength of expiration email...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned