The module should use double-quotes instead of apostrophes (single quotes) for L10n variables, because these strings can contain unescaped single quotes. Single quotes are very common in French, for instance.

Example of code broken by an unescaped quote, on line 165:

link.innerHTML = '$enable';

should be

link.innerHTML = "$enable";

Otherwise, the "enable rich-text" link doesn't work anymore when translated by "activer l'éditeur" (French translation, that contains a single quote). The workaround obviously is to escape the single quote in the string, which I did after a 1 hour investigation. After all, end users are not supposed to know they need to escape characters in their L10n strings...

Cheers,

Vianney Stroebel

----------------------------------------------------------------------
http//co-org.net
Plate-forme collaborative gratuite pour les associations, basée sur Drupal.

Comments

Viybel’s picture

Viybel commented

Sorry, I've just realized that:

link.innerHTML = "$enable";

doesn't make any sense.

Instead, I guess we could get rid of the quotes altogether:

link.innerHTML = $enable;

But then, what were the quotes for in the first place?

Cheers,

Vianney Stroebel

----------------------------------------------------------------------
http//co-org.net
Plate-forme collaborative gratuite pour les associations, basée sur Drupal.

pomliane’s picture

pomliane commented
Status: Active » Closed (won't fix)

This version of TinyMCE is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.