Quickedit assumes that $info['content'] is already rendered content which is not exclusively the case, so we need handling for when it's an array and when it's a string.

Eclipse

CommentFileSizeAuthor
#3 2443037-3.patch1008 byteseclipsegc
#1 2443037-1.patch961 byteseclipsegc

Comments

eclipsegc’s picture

eclipsegc commented
Status: Active » Needs review
StatusFileSize
new 2443037-1.patch961 bytes

Code!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work 
+++ b/includes/panelizer.inc
@@ -22,7 +22,14 @@ function quickedit_ctools_render_alter(&$info, &$page, &$context) {
+        // Sometimes the content is already rendered, sometimes it's not.

Would be great if this gave at least one example of where this happens.

(It seems any time CTools is involved, the data we're dealing with can be in multiple forms :/)

eclipsegc’s picture

eclipsegc commented
StatusFileSize
new 2443037-3.patch1008 bytes

Yes, ctools implementations often predate render arrays, so sometimes you're dealing with code that was written with D6 in mind and then re-engineered to allow for D7 style approaches. This is one of those times.

Hopefully this gives clearer direction as to the "why"

Eclipse

eclipsegc’s picture

eclipsegc commented
Status: Needs work » Needs review

me and that status...

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Fixed

Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Followup: #2545666: Undefined index in quickedit_ctools_render_alter() for response handlers