Corrected the disparity between the definition and the annotation of $state.

Plus fixed an ultra trivial newline issue while I was double checking the class.

CommentFileSizeAuthor
#5 ViewsLocalTask-2442339-5.patch521 bytesmrjmd
state-0.patch988 bytesmartin107

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Documentation is not frozen in beta. Committed fd3b047 and pushed to 8.0.x. Thanks!

  • alexpott committed fd3b047 on 8.0.x 
    Issue #2442339 by martin107: ViewsLocalTask param annotation bug
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Fixed » Needs work

That second part in the patch, adding the blank line, I think was incorrect. That @code section was supposed to be part of the @return docs and now it isn't. Please make a new patch that removes the blank line that was added here:

    * @return array
    *   A list of arrays containing the $view and $display_id.
+   *
    * @code
    * array(
    *   array($view, $display_id),
mrjmd’s picture

mrjmd commented
Status: Needs work » Needs review
StatusFileSize
new ViewsLocalTask-2442339-5.patch521 bytes

Here's a patch re: #4.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b5500b6 and pushed to 8.0.x. Thanks!

  • alexpott committed b5500b6 on 8.0.x 
    Issue #2442339 followup by mrjmd: ViewsLocalTask param annotation bug

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.