Changing text formats on a field makes it impossible to edit.

It works if you disabled the javascript. So it should be a javascript issue.

So, lot's of issues it seems with ckeditor and textfields - see https://www.drupal.org/node/971632
Looks like ckeditor by default isn't designed to work with them ..

Why do we even attach an editor to it anyway ? It feels very weird to me. But it also makes little sense on a storage level because you're limited to 255 chars by default.

So, there are a couple of options

- remove text formatted - might be little hard since we do allow it in D7 as well
- do not attach ckeditor to textfields - if you really want one, use long, the use case just makes more sense on a textarea input.

Talked with alexpott - The idea is that we would add a configuration option to the Editor plugin that allows us to tell whether an editor works on a textfield input or not.

Working on a patch for proof of concept.

This adds 'supports_textfields' to the annotation.

Why do we even attach an editor to it anyway ? It feels very weird to me. But it also makes little sense on a storage level because you're limited to 255 chars by default.

Exactly.

What about this alternative approach? I don't think it ever makes sense to attach a rich text editor to something that cannot even fit a rich text. So then I think we can take this simpler approach.

Something like this would easily allow contrib to still support #base_type => textfield.

So something like this ?

What's the best way to test this ? assertRaw on javascript settings ?

1. +++ b/core/modules/editor/src/Annotation/Editor.php
   @@ -62,4 +62,11 @@ class Editor extends Plugin {
   +   * A list of element types this editor supports.
   

   s/editor/text editor/

2. +++ b/core/modules/editor/src/Annotation/Editor.php
   @@ -62,4 +62,11 @@ class Editor extends Plugin {
   +   * @var array
   

   string[]

3. +++ b/core/modules/editor/src/Annotation/Editor.php
   index 1631ec9..9d0f77e 100644
   --- a/core/modules/editor/src/EditorInterface.php
   
   +++ b/core/modules/editor/src/EditorInterface.php
   @@ -79,4 +79,12 @@ public function getImageUploadSettings();
   +  public function getSupportedElementTypes();
   
   +++ b/core/modules/editor/src/Element.php
   index 71cfbef..73844a0 100644
   --- a/core/modules/editor/src/Entity/Editor.php
   

   Why do this at the config entity level?

   If you grep the code base for is_xss_safe, you'll see how that other annotation is handled, IMO it should be handled similarly.

RE: how to test: see EditorLoadingTest. You'll want to add a "Text (formatted)" field to e.g. the "page" bundle (not "article", because that's already used for the existing tests). And then something like:

    $this->drupalLogin($this->privilegedUser);
    $this->drupalGet('node/add/bundle');
    list( , $editor_settings_present, $editor_js_present, $body, $format_selector) = $this->getThingsToCheck();
    $this->assertFalse($editor_settings_present, 'No Text Editor module settings.');
    $this->assertFalse($editor_js_present, 'No Text Editor JavaScript.');
    $textfield = … some xpath.
    $this->assertTrue(count($textfield) === 1, 'A textfield exists.');
    $this->assertTrue(count($format_selector) === 1, 'A single text format selector exists on the page.');

… to test the case of a text editor like CKEditor, which does not support #type => textfield. But you'll probably want to test the inverse too: a text editor that does support that.

Test patch - will fix the rest of the review after this comes back

re: 13

1. Fixed
2. Fixed
3. Ok, makes sense (fixes the fail in the previous patch as well at the same time)
4. Tests added: tests unicorn which supports textfields, ckeditor which doesn't.

Mostly nitpicks, one more problematic thing.

1. +++ b/core/modules/editor/src/EditorInterface.php
   @@ -44,6 +44,14 @@ public function getFilterFormat();
      /**
   +   * Set the text editor plugin ID.
   +   *
   +   * @return \Drupal\editor\EditorInterface
   +   *   The called editor entity.
   +   */
   +  public function setEditor($editor);
   

   Missing @param docs.

   Also: good catch (that that was missing).

2. +++ b/core/modules/editor/src/Entity/Editor.php
   @@ -81,6 +81,7 @@ public function __construct(array $values, $entity_type) {
   +    $definition = $plugin->getPluginDefinition();
   

   This is now obsolete.

3. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -21,7 +23,7 @@ class EditorLoadingTest extends WebTestBase {
   -  public static $modules = array('filter', 'editor', 'editor_test', 'node');
   +  public static $modules = array('filter', 'editor', 'editor_test', 'node', 'ckeditor');
   

   The editor module's tests specifically don't depend on ckeditor module. I'm afraid that means you'll have to introduce another dummy text editor, besides the Unicorn one. The upside: you get to pick a funky name! :D

4. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -63,16 +65,42 @@ protected function setUp() {
   +    // Create textfield.
   

   Create a formatted text field, which uses an <input type="text">.

5. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -63,16 +65,42 @@ protected function setUp() {
   +    entity_create('field_storage_config', array(
   

   FieldStorageconfig::create(

6. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -63,16 +65,42 @@ protected function setUp() {
   +    entity_create('field_config', array(
   

   FieldConfig::create(

7. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -160,7 +188,7 @@ public function testLoading() {
   -    // Create an "article" node that users the full_html text format, then try
   +    // Create an "article" node that uses the full_html text format, then try
   

   Hah :)

8. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -183,7 +211,62 @@ public function testLoading() {
   +  public function testSupportedElementTypes() {
   +
   +    // Associate the unicorn text editor with the "Full HTML" text format.
   

   Extraneous blank line.

9. +++ b/core/modules/editor/tests/modules/src/Plugin/Editor/UnicornEditor.php
   @@ -19,7 +19,10 @@
   + *   supported_element_types = {
   + *     "textarea", "textfield"
   + *   }
   

   I think we usually put these on multiple lines?

timezones++
working on nits, will re-assign to swentel when done

introducing T-Rex editor :)
fixes #21

LOL t-rex +1

https://img0.etsystatic.com/052/0/6769124/il_570xN.700722414_rsvc.jpg

fixing fails

you need to summon the t-rex

embedding @swentel's image

Looks good to me! RTBC?

Text Field Settings BEFORE

Text Field Settings AFTER

Text Field Content

Text Field Content Saved

swentel++
larowlan++

1. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -47,6 +50,10 @@ class EditorLoadingTest extends WebTestBase {
   +    // Let there be T-rex.
   

   :D

2. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
   @@ -47,6 +50,10 @@ class EditorLoadingTest extends WebTestBase {
   +    \Drupal::state()->set('editor_test_give_me_a_trex_thanks', TRUE);
   

   :D

3. +++ b/core/modules/editor/tests/modules/config/schema/editor_test.schema.yml
   @@ -7,3 +7,11 @@ editor.settings.unicorn:
   +editor.settings.trex:
   +  type: mapping
   +  label: 'T-Rex settings'
   +  mapping:
   +    stumpy_arms:
   +      type: boolean
   +      label: 'Stumpy arms'
   

   <3