Closed (fixed)
Project:
Web Links
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Feb 2015 at 17:47 UTC
Updated:
12 Aug 2015 at 17:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
gstegemann commentedOops, yes. No, I haven't noticed it before.
Comment #2
jonathan1055 commentedThe code which displays the group description is in weblinks_get_tree()
So it appears that we are explicitly supressing the description when
->collapsibleis not set. I cannot see any reason for this, can you?Comment #3
gstegemann commentedI have no idea. Maybe Nancy can remember. Maybe to display less information when groups cannot be collapsed.
I would say it is implemented intentionally that way, including the D6 version of Web Links. How about adding a Links page setting to show/not to show the group descriptions on the Links page? Or to add a similar setting on the Taxonomy configuration page?
Comment #4
jonathan1055 commentedWe already do have that setting in the Groups fieldset - see attached. That is what controls the
$show_descvariable in the code snippet above.I think we should honor that setting if it is turned on, by showing the description regardless of whether the fieldset is collapsible. Attached is a patch which does this, and also simplifies the logic.
Comment #5
gstegemann commentedTested and is working.
Comment #7
jonathan1055 commentedGreat stuff! Thank you.
Comment #10
jonathan1055 commentedI'm not intending to port all bug fixes to 6.x but I already had the patch for this one. Simple to do - same as 7.x
I had to add the
'#attributes'entry to the fieldset array to avoid a php5 warning from theme_fieldset() in form.incComment #11
gstegemann commentedThat's OK.
And tested and works. Thanks.
Comment #13
jonathan1055 commentedExcellent.
Comment #15
jonathan1055 commentedSuddenly all the old D6 patches are being re-tested. We can ignore this. The code is committed as per #12 and issue is fixed.