This is a strange one surprised no one has noticed it or reported it before. When the setting 'Make groups collapsible' is 'No' then the group descriptions are not shown. Turning the option back to 'Yes' and you get the descriptions again. I hope this will be simple to fix.

Comments

gstegemann’s picture

Oops, yes. No, I haven't noticed it before.

jonathan1055’s picture

The code which displays the group description is in weblinks_get_tree()

$new_tree[$tid]->desc = NULL;
if ($show_desc && $new_tree[$tid]->collapsible) {
  if ($term->description) {
    $new_tree[$tid]->desc = '<div class="weblinks-cat-desc">' . check_markup($term->description, $format, '', FALSE) . '</div><!--class="weblinks-cat-desc"-->';
  }
}
else {
  $new_tree[$tid]->desc = '';
}

So it appears that we are explicitly supressing the description when ->collapsible is not set. I cannot see any reason for this, can you?

gstegemann’s picture

I have no idea. Maybe Nancy can remember. Maybe to display less information when groups cannot be collapsed.

I would say it is implemented intentionally that way, including the D6 version of Web Links. How about adding a Links page setting to show/not to show the group descriptions on the Links page? Or to add a similar setting on the Taxonomy configuration page?

jonathan1055’s picture

How about adding a Links page setting to show/not to show the group descriptions on the Links page?

We already do have that setting in the Groups fieldset - see attached. That is what controls the $show_desc variable in the code snippet above.

I think we should honor that setting if it is turned on, by showing the description regardless of whether the fieldset is collapsible. Attached is a patch which does this, and also simplifies the logic.

gstegemann’s picture

Status: Needs review » Reviewed & tested by the community

Tested and is working.

  • jonathan1055 committed eacfa7a on 7.x-1.x
    Issue #2431367 by jonathan1055: Group descriptions are not shown when '...
jonathan1055’s picture

Status: Reviewed & tested by the community » Fixed

Great stuff! Thank you.

  • jonathan1055 committed af8006d on 7.x-1.x
    Issue #2431367 by jonathan1055: Group descriptions are not shown when '...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055’s picture

Version: 7.x-1.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new1.48 KB

I'm not intending to port all bug fixes to 6.x but I already had the patch for this one. Simple to do - same as 7.x
I had to add the '#attributes' entry to the fieldset array to avoid a php5 warning from theme_fieldset() in form.inc

gstegemann’s picture

Status: Needs review » Reviewed & tested by the community

I'm not intending to port all bug fixes to 6.x but I already had the patch for this one.

That's OK.

And tested and works. Thanks.

  • jonathan1055 committed 06117e6 on
    Issue #2431367 by jonathan1055: Group descriptions are not shown when...
jonathan1055’s picture

Status: Reviewed & tested by the community » Fixed

Excellent.

Status: Fixed » Needs work
jonathan1055’s picture

Status: Needs work » Fixed

Suddenly all the old D6 patches are being re-tested. We can ignore this. The code is committed as per #12 and issue is fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.