Modules are meant to be enabled and disabled. That's why the modules page provides a UI for that in Drupal. What's the purpose of this secondary on/off switch? Is there a use-case for having the module enabled, but this setting disabled? If not, should the Module Status setting be removed?

CommentFileSizeAuthor
#3 login_redirect-remove_enabled_setting-2431197-3.patch3.46 KBperennial.sky
#1 login_redirect-remove_enabled_setting-2431197.patch2.93 KBjenlampton

Comments

jenlampton’s picture

jenlampton
she / her
commented
Status: Active » Needs review
StatusFileSize
new login_redirect-remove_enabled_setting-2431197.patch2.93 KB

On closer examination of the code, I think this setting may have been added due to the way validation was being handled. Perhaps the change in [#2431147 will make this setting unnecessary. This patch depends on the one in the linked issue.

Status: Needs review » Needs work

The last submitted patch, 1: login_redirect-remove_enabled_setting-2431197.patch, failed testing.

perennial.sky’s picture

perennial.sky commented
StatusFileSize
new login_redirect-remove_enabled_setting-2431197-3.patch3.46 KB

#1 patch forget to remove status variable from install file

perennial.sky’s picture

perennial.sky commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: login_redirect-remove_enabled_setting-2431197-3.patch, failed testing.

perennial.sky’s picture

perennial.sky commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.