Re-add tests when CRM Core is on drupal.org

Updated EventProcessingTest, ProcessContactTest and EventSubscriberTest in #2475937: Update collect_crm_core_contact module with latest changes

Updated EventProcessingTest and extended ProcessContactTestwith the changes in #2476539: Extend contact matcher and contact creation to support user URIs.

Oops, some tests are missing... Here is the full patch.

Updated failing EventSubscriberTest and ProcessContactTest with the latest Collect changes, changed some doc comments.

Updated ProcessContactTest with the changes made in #2532262: Make sure that order of processors is guaranteed

Updated and fixed ProcessContactTest with the changes made in CRM Core/Collect. It is passing now and it is part of re_add_tests_when_crm-2430111-16.patch.

Also updated and fixed what is possible in EventProcessingTest (CRM Core, Collect changes, schema errors...) but it is failing on processing. I guess that is because of #2441983: Remove event-based processing. When we complete related issue the code will be changed again.

EventSubscriberTest tests removed EventSubscriber code, so the test should be removed too. However, adding these 2 files as a part of re_add_tests_when_crm-2430111-16-old-tests.patch...

I'll replace the patch we use on D8 status (for additional CRM testing) with re_add_tests_when_crm-2430111-16.patch.

Hm... We should decide asap how to proceed with event processing.

Either remove if and also move all related tests to the other issue... so we have a single set of things that are subject to be readded once event processing is a topic again.

Or we discuss and decide how to deal with delayed post processing. (And possibly readd it the way we want it.)

Expanding CRM tests with CollectDemoTest from #2519966: Demo article is not displayed on the front page.

It will be included in D8 status testing from today.

Fix for #507488: Convert page elements (local tasks, actions) into blocks.

Updates in CollectDemoTest after #2064191: Fix the 'target_bundle' field setting - 'target_bundles' are not validated when entity_reference is enabled.

The updates mentioned above will be fixed in #2580413: Remove target_bundle setting from Collect Demo config files. Uploading the old patch.

Since CRM Core is now on d.o we can reupload the last patch for testing.

Created 2 issues that would need to go before adding CRM tests:
- #2693501: Fix failing ProcessingWebTest
- #2693507: Fix schema errors in Collect demo

Since CollectDemoTest is going to be fixed and added in #2693507: Fix schema errors in Collect demo, we can upload ProcessContactTest here.

I think it might be easier to just wait for #2691343: Merge crm_core_activity_ui into crm_core_activity to land, then we can fix the changed dependencies before committing it.

Let's check the tests after #2691343: Merge crm_core_activity_ui into crm_core_activity was committed.

Hm, testbot tries to checkout crm_core twice. Strange error.

It looks like testbot tries to checkout to 8.x-2.x branch of CRM Core where we don't have #2691343: Merge crm_core_activity_ui into crm_core_activity committed.

Updated version dependencies in Collect CRM module.

The same error should be because of the Testbot dependency-reload process:

I changed dependencies in my .info file, but the wrong dependencies are still being loaded on test Dependencies only get built when the new dev release is rolled, every 12 hours. So if you change dependencies, it won't be reflected until the new dev tarball is rolled.

Edit: This probably means we have to commit dependency changes and wait at most 12 hours...

One more change.

Edit: Adding version dependencies prevents me to enable the module locally. I get: "Module collect_demo cannot be enabled because it depends on crm_core_contact (1.x) but 1.x-dev is available"

Added a dependencies patch with correct versions.

Testbot is doing checkout 8.x-1.x and then on 8.x-2.x. Do we need to add version dependencies in CRM Core as well? (crm_core_match.info, crm_core_activity.info etc)

Committed that patch.

Thanks. Here is the test patch.

This should fix "Block" issue.

Edit: I guess the other test fails are related to broken access check which will be fixed after #2696669: Incomplete/broken access checking in EntityController::addPage() and #2691337: Merge crm_core_contacts_ui into crm_core_contacts.

There is another error that we get while creating an "entity_test" entity which occurs with #43 (access check) and #39 (merge contact).

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'uuid' in 'field list': INSERT INTO {entity_test} (type, uuid, langcode, name, created, user_id) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array
(
    [:db_insert_placeholder_0] => gift
    [:db_insert_placeholder_1] => 4a023cd3-5ba2-4f38-8592-077c375dbf2a
    [:db_insert_placeholder_2] => en
    [:db_insert_placeholder_3] => Cookie
    [:db_insert_placeholder_4] => 1460111563
    [:db_insert_placeholder_5] => 1
)

Ok, this patch passes locally with #43 (access check) and #39 (merge contact) patches applied.

#2696669: Incomplete/broken access checking in EntityController::addPage() and #2691337: Merge crm_core_contacts_ui into crm_core_contacts were committed, rerolling.

And.. finally in ;)