Problem/Motivation

There are is a failing ProcessingWebTest that breaks Collect HEAD.

Tested locally:

Drupal\collect\Tests\ProcessingWebTest
Tests processing with Collect.
33 passes, 21 fails, 6 exceptions, 9 debug messages

Proposed resolution

Go through the test and fix the errors.

CommentFileSizeAuthor
#6 remove-sleep-2693501-6.patch904 bytesberdir

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Title: Fixed failing ProcessingWebTest » Fix failing ProcessingWebTest
mbovan’s picture

mbovan commented

Update: Debugged this. The error that I'm getting after adding a processor (to a collect model) and saving the form is: "The entity does not have an ID".

It seems that Model entity somehow loses its "id" (it's NULL) after I click on "Submit". As I can see all other properties of the model (including original id) are untouched - only "id" is missing.

mbovan’s picture

mbovan commented
Assigned: Unassigned » mbovan
mbovan’s picture

mbovan commented
Assigned: mbovan » Unassigned

Cannot assign to @Berdir. :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new remove-sleep-2693501-6.patch904 bytes

#2650588: Entities with plugin collections should be updated before serialization broke this.

The problem was this line:

unset($vars[array_search($unset_var, $vars)]);. $unset_var was already removed from $vars, so array_search() returned FALSE. that returned 0 and it removed the id from the serialized array.

Now that I found it, it makes all sense and a I think I've even seen this before.

This was added to 8.0.x too, so it is safe to remove.

  • Berdir committed cf60310 on 8.x-1.x 
    Issue #2693501 by Berdir: Fix failing ProcessingWebTest
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

And committed.

mbovan’s picture

mbovan commented

Great! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.