Closed (fixed)
Project:
Panelizer (obsolete)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Feb 2015 at 15:57 UTC
Updated:
10 Jun 2015 at 11:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
stevectorAfter seeing this issue I went to admin/structure/types/manage/article/display on my current project and saw that most of my panelized View modes still were configured to render fields through core. For one view mode I dragged all fields to hidden and looked at a View with 12 nodes. I don't have thorough numbers; just one page load of data from xhprof before and after. The time spent in field_default_view() dropped from .65 seconds to .25. I'd prefer to have more robust data. But I think that indication is enough for me to "hide" through the Core UI every field on every panelized view mode. I'll probably do that with an update function followed by a features update.
Comment #2
stevectorHere's a quick and dirty patch that uses hook_requirements to detect if panelized view modes still have core configuration that displays fields. There are plenty of todos and the UI verbiage could be better. To see what it does
1. Make sure that at least one panelized view mode also has Core configuration to show fields. For instance, if article teasers are Panelized, go to admin/structure/types/manage/article/display/teaser and confirm that at least one field is not in the "hidden" grouping. One or more fields not "hidden" is that problem state that this patch detects.
2. Go to admin/reports/status and confirm that a warning message now shows from Panelizer.
And Damien, I apologize if I'm hijacking the intent of this issue. It certainly could be split out into a different issue. As I read node_view() there does not seem to be a clean way to block Core from doing what Core does. This hiding of fields seems like decent mitigation.
Comment #3
stevectorComment #4
stevectorHere's an updated version that also gives a warning on "Manage Display" tabs.
Comment #5
damienmckennaThanks. I've updated it a bit, and now it supports all entities; I tested it with a users and a content type.
Comment #6
damienmckennaMinor wording change.
Comment #7
damienmckennaCommitted. Thanks stevector!