AggregatorFeedBlock does not output item links

confirm patch fixes problem.

Related to #1763964: Use #type => link for theme_aggregator_block_item(), should be an easy fix.

+++ b/core/modules/aggregator/src/Plugin/Block/AggregatorFeedBlock.php
@@ -170,9 +171,13 @@ public function build() {
-          '#href' => $item->getLink(),
+          '#url' => Url::fromUri($item->getLink()),

Can't we just do this instead?

  '#url' => $item->urlInfo(),

Ok, I'm removing an extraneous use statement we no longer need. I'll let it come back from NR, but this should be RTBC at this point.

Testing this and it works as advertised and fixes a big bug in HEAD. I'd say this falls within the criteria for critical since it "Render a system unusable and have no workaround." Aggregator block is definitely unusable at this point.

Eclipse

Since I only removed a use statement, I feel comfortable RTBCing this patch.

Eclipse

+1 tested looks good. Without this patch, aggregator is unusable, thus I'd agree its a critical issue.

+++ b/core/modules/aggregator/src/Plugin/Block/AggregatorFeedBlock.php
@@ -163,9 +163,13 @@ public function build() {
       $rendered_items = array();
       foreach ($items as $item) {
+        if (!$item->getLink()) {
+          // No link, ignore it.

So $item->getLink() points to the external URL, right?
On the other hand, $item->urlInfo() points to an internal URL, ... this is a bit confusing. Does someone know, where my logic problem exists?

Frankly, the old code that was there didn't have this check, I think it's likely to be unnecessary. Let's try it without. (I'm guessing the check was introduced before the #href -> #url change was made or something)

Eclipse

@dawehner Item::buildUri() return the external URL. this happens to be the uri_callback of Item entity, which means urlInfo() for this entity will always be external

AAH, this is not obvious. Thank you!

Committed fe6ef2a and pushed to 8.0.x. Thanks!

This feels more like a major than a critical since it only affects an optional sub system - but not going to quibble at this point :)