Problem/Motivation

BlockContentFieldTest has the following information in the docblock:

<?php
/**
 * Tests block fieldability.
 *
 * @group block_content
 * @todo Consider removing this test when https://drupal.org/node/1822000 is
 * fixed.
 */
class BlockContentFieldTest extends BlockContentTestBase {
?>

And #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest already went in.

After asking Berdir, this adds an equivalent test coverage for the link field: #1957748-24: hook_field_prepare_view() is passed empty field values for EntityNG Entities.

Proposed resolution

Remove the testfile

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2428633-remove_BlockContentFieldTest-1.patch3.23 KBpcambra
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Status: Active » Needs review
FileSize
2428633-remove_BlockContentFieldTest-1.patch3.23 KB
amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Reviewed & tested by the community

Yay for one less web test :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Tests are not frozen in beta. Committed 374a5bd and pushed to 8.0.x. Thanks!

  • alexpott committed 374a5bd on 8.0.x 
    Issue #2428633 by pcambra: Remove unnecessary BlockContentFieldTest
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Damn I was using this test in the block content cache contexts critical

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.