Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
contact.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2015 at 08:34 UTC
Updated:
14 Mar 2015 at 17:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
larowlanThanks, we might have this in contact_storage already.
Comment #2
berdircontact_storage only has the admin permission.
Comment #3
mbovan commentedAdded AccessControlHandler class and admin_permission for Message entity entity type.
Comment #4
berdirWe're not testing that at the moment, not sure how we want to do that.
Maybe we could check for contact message create access instead of contact_form view access on contact.site_page_form?
Comment #5
berdirComment #6
mbovan commentedAdded tests coverage.
Comment #7
berdirComment #9
berdirFailed as expected.
@mbovan: If you upload the test only patch first, then the issue status will not be set back to needs work.
Comment #10
larowlanCan you make the array format consistent on these lines? We shouldn't mix old form
array()and new form[]in the one line. Personal preference is on [], but let you decide ;)Minor nit, other than that - looks great - thank you for the patch and the test!
Comment #11
berdirComment #12
dashaforbes commentedChanged array syntax lines 68 and 69 as per comment #10
Comment #13
dashaforbes commentedchanged patch name
Comment #14
dashaforbes commentedComment #17
dashaforbes commentedComment #19
dashaforbes commentedComment #20
dashaforbes commentedComment #21
berdir@dashaforbes: Remember to provide an interdiff when working on an existing patch, had to download and diff myself to make sure that only the requested changes were made. See https://www.drupal.org/documentation/git/interdiff.
Comment #22
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 4f33bd4 and pushed to 8.0.x. Thanks!