Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
schortcut.theme.css
contains the following CSS:
.edit-shortcuts {
display: block;
}
For the Edit shortcuts link in the toolbar. toolbar.module.css
, however, already contains contains the following:
.toolbar a {
display: block;
line-height: 1;
}
The edit-shortcuts
class is applied to a link in the toolbar, so both rules apply and the latter one is more specific. Therefore the rule in Shortcut module is completely superfluous.
Proposed resolution
Remove the respective CSS in Shortcut module.
Remaining tasks
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2426973-1-shortcut-css.patch | 417 bytes | tstoeckler |
shortcut-css.png | 125.55 KB | tstoeckler |
Comments
Comment #1
tstoecklerHere we go.
Comment #2
mortendk CreditAttribution: mortendk commentedwere doing a csslint cleanup over here #2421385: shortcut cssfile cleanup im pretty sure we cleaned that out as well
Comment #3
tstoecklerHmm... I'm not sure I see that particular block being touched there. Care to elaborate @mortendk?
Comment #4
mortendk CreditAttribution: mortendk commentedups your right, it was a bit late at night ;)
gonaa review this as i looked at it anyways
Comment #5
mortendk CreditAttribution: mortendk commentedWorks as intended
.toolbar
a set the display block (toolbar.module.css)Comment #6
alexpottCSS is not frozen in beta. Committed b9e2e7e and pushed to 8.0.x. Thanks!