Problem/Motivation

schortcut.theme.css contains the following CSS:

.edit-shortcuts {
  display: block;
}

For the Edit shortcuts link in the toolbar. toolbar.module.css, however, already contains contains the following:

.toolbar a {
  display: block;
  line-height: 1;
}

The edit-shortcuts class is applied to a link in the toolbar, so both rules apply and the latter one is more specific. Therefore the rule in Shortcut module is completely superfluous.

A screenshot of the content page with Firebug proving that the Shortcut CSS is not necessary.

Proposed resolution

Remove the respective CSS in Shortcut module.

Remaining tasks

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 2426973-1-shortcut-css.patch417 byteststoeckler
shortcut-css.png125.55 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
417 bytes

Here we go.

mortendk’s picture

were doing a csslint cleanup over here #2421385: shortcut cssfile cleanup im pretty sure we cleaned that out as well

tstoeckler’s picture

Hmm... I'm not sure I see that particular block being touched there. Care to elaborate @mortendk?

mortendk’s picture

Issue tags: +CSS, +frontend

ups your right, it was a bit late at night ;)
gonaa review this as i looked at it anyways

mortendk’s picture

Status: Needs review » Reviewed & tested by the community

Works as intended .toolbar a set the display block (toolbar.module.css)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

CSS is not frozen in beta. Committed b9e2e7e and pushed to 8.0.x. Thanks!

  • alexpott committed b9e2e7e on 8.0.x
    Issue #2426973 by tstoeckler: shortcut.theme.css makes .edit-shortcuts...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.