Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
shortcut.module.css Dont contain any essential css for the module to work, according to our css standards (MAT filenaming) we should move the css to its correct file, in this case shortcut.theme.css. to make the life easier for the themer to understand whats going on.
[#1887922]
Proposed resolution
merge shortcut.module.css into shortcut.icons.theme.css
Remaining tasks
* test the patch applies
* screenshots of shortcut module with & without shortcut.icons.theme.css in seven.
* screenshots of shortcut module with & without shortcut.icons.theme.css in stark
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | shortcut_theme-2421385-3.patch | 1.39 KB | mortendk |
| #5 | shortcut-css-interdiff.txt | 1020 bytes | mortendk |
| #5 | shortcut_theme-2421385-2.patch | 2.13 KB | mortendk |
| #1 | shortcut_theme-2421385-1.patch | 3.26 KB | mortendk |
| #1 | shortcut-no-thene.png | 61.37 KB | mortendk |
Comments
Comment #1
mortendk CreditAttribution: mortendk commentedAttached screenshots & cleaned it up even more as module.css is not needed as all is visual styles
No theme:
with theme.css file
Comment #2
LewisNymanComment #3
kandra CreditAttribution: kandra commentedI've tried to apply this patch, but it no longer applies.
Comment #4
kandra CreditAttribution: kandra commentedThis issue conflicts with the directions on https://www.drupal.org/node/2421373 (which asks to rename *.icons.css files to *.icons.theme.css). However the current issue deletes the shortcut.icons.theme.css files by merging it with the shortcut.theme.css.
What's the final direction on this issue?
Comment #5
mortendk CreditAttribution: mortendk commentedrerolled
Comment #6
mortendk CreditAttribution: mortendk commentedsorry heres the right patch
im gonna update the issue naming icon files to
modulename.icon.theme.cssnew patch should reflect thatComment #7
mortendk CreditAttribution: mortendk commentedComment #8
mortendk CreditAttribution: mortendk commentedComment #9
LewisNymanChanged references to shortcut.theme.css to shortcut.icons.theme.css
Comment #10
LewisNymanTagging with novice for the sprint at Drupalcon tomorrow
Comment #11
joelpittet@mortendk Can you reply to @kandra's comment in #4
Comment #12
joelpittetOtherwise this looks RTBC to me.
Comment #13
mortendk CreditAttribution: mortendk commented@joel the issue with shprtcuts.icon.theme as asked for in #4 got fixed in #6
Comment #14
mortendk CreditAttribution: mortendk commentedComment #15
joelpittetTime flies, I should have checked the link myself. RTBC
Comment #16
alexpottCSS is not frozen in beta. Committed ec408a1 and pushed to 8.0.x. Thanks!