Problem/Motivation

the .indentation class is required for table drag to work, but the class is not prefixed with .js- as our css documentation requires & it also makes it recognizable for the themer, that this class is not used for pretty colors ;)

formatting https://www.drupal.org/node/1887918#formatting

Proposed resolution

rename .indentation to .js-indentation

Remaining tasks

* screenshots of table drag maanger (theres on on the menu admin)
* seven theme
* stark theme

User interface changes

API changes

CommentFileSizeAuthor
#11 indentation-class-js-prefix-11.patch10.47 KBbrahmjeet789
#5 post-patch.gif427.87 KBmortendk
#3 indentation-class-js-prefix-2.diff11.72 KBmortendk
indentation-class-js-prefix.diff10.39 KBmortendk

Comments

mortendk’s picture

mortendk commented
Status: Active » Needs review

gotowork bot

Status: Needs review » Needs work

The last submitted patch, indentation-class-js-prefix.diff, failed testing.

mortendk’s picture

mortendk commented
Status: Needs work » Needs review
StatusFileSize
new indentation-class-js-prefix-2.diff11.72 KB

should fix the test errors

mortendk’s picture

mortendk commented
Issue tags: +Needs screenshots
mortendk’s picture

mortendk commented
Issue summary: View changes
Issue tags: -Needs screenshots
StatusFileSize
new post-patch.gif427.87 KB

anim gif to show theres no regression

mortendk’s picture

mortendk commented
Issue tags: +banana
lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: -JS +JavaScript
mortendk’s picture

mortendk commented

2 mentions of the

found
shold be corrected 
 2358      },
 2359      tableDragIndentation: function () {
 2360:       return '<div class="indentation">&nbsp;</div>';
 2361      },
 2362      tableDragChangedWarning: function () {

/Users/erno/dev-www/drupal8/sites/default/files/js/js_jrdMrp20Xs7_Qm3OMykp4Z--2_QSAbqotAyfYGd5FVE.js:
 2363      },
 2364      tableDragIndentation: function () {
 2365:       return '<div class="indentation">&nbsp;</div>';
 2366      },
 2367      tableDragChangedWarning: function () {<h4></h4>
DickJohnson’s picture

DickJohnson commented
Status: Needs review » Needs work

Did some grepping and found these.

/drupal8/sites/default/files/js/js_9XHVbeUhv5LJolPMI3bcC6RIXvhHb7LjXKT8ZEa8HLA.js:
 2358      },
 2359      tableDragIndentation: function () {
 2360:       return '<div class="indentation">&nbsp;</div>';
 2361      },
 2362      tableDragChangedWarning: function () {

/drupal8/sites/default/files/js/js_jrdMrp20Xs7_Qm3OMykp4Z--2_QSAbqotAyfYGd5FVE.js:
 2363      },
 2364      tableDragIndentation: function () {
 2365:       return '<div class="indentation">&nbsp;</div>';
 2366      },
 2367      tableDragChangedWarning: function () {
mortendk’s picture

mortendk commented
Status: Needs work » Needs review
Issue tags: +jsbanana

@dickjohnson looks like your casche wasnt cleared & you found old data in tabledrag.js

brahmjeet789’s picture

brahmjeet789 commented
StatusFileSize
new indentation-class-js-prefix-11.patch10.47 KB

Hi @mortendk i think you missed the file TaxonomyTermIndentationTest.php i have changed it please check is it fine or not

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

I manually tested this patch in Classy and Seven and it works as expected. I also looked for any missed instances of indentation that we missed and couldn't find any.

  • webchick committed 2a9b4e9 on 8.0.x 
    Issue #2426595 by mortendk, brahmjeet789, LewisNyman, DickJohnson:...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Markup/CSS changes are allowed during beta.

Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: rename indentation class to js-indentation » Rename indentation class to js-indentation

Published the change notice.